Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

findbestmatchingname_fn(): catch possible problems if best (vp) 

contains some strange name (shouldn't happen, but ...)

Coverity CID 869
This commit is contained in:
hubertf 2006-03-17 02:20:46 +00:00
parent 237c0ec2a5
commit fc4fb72e38
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
usr.sbin/pkg_install/lib/str.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: str.c,v 1.59 2006/03/17 02:10:55 hubertf Exp $ */
/* $NetBSD: str.c,v 1.60 2006/03/17 02:20:46 hubertf Exp $ */
#if HAVE_CONFIG_H
#include "config.h"
@ -11,7 +11,7 @@
#if 0
static const char *rcsid = "Id: str.c,v 1.5 1997/10/08 07:48:21 charnier Exp";
#else
__RCSID("$NetBSD: str.c,v 1.59 2006/03/17 02:10:55 hubertf Exp $");
__RCSID("$NetBSD: str.c,v 1.60 2006/03/17 02:20:46 hubertf Exp $");
#endif
#endif
@ -307,9 +307,15 @@ findbestmatchingname_fn(const char *found, void *vp)
if (best_version) {
/* skip '-' if any version found */
best_version++;
strip_txz(best_no_sfx, NULL, best_version);
best_version = best_no_sfx;
} else {
/* how did this end up in 'best'?
* Shouldn't happen... */
fprintf(stderr,
"'%s' has no usable package(version)\n",
best);
}
strip_txz(best_no_sfx, NULL, best_version);
best_version = best_no_sfx;
}
if (found_version == NULL) {