Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

As fd_lastfile might be negative, we can't use the (u_int) cast trick to 

compare fd and fdp->fd_lastfile in fdrelease(), so change the test to a
more explicit one.  Spotted by Matt Thomas.

Should fix the panic reported by Matthias Scheler.
This commit is contained in:
cube 2005-01-14 00:25:12 +00:00
parent db5b1f2fa2
commit fade05f67f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/kern/kern_descrip.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: kern_descrip.c,v 1.128 2005/01/12 20:41:45 cube Exp $ */
/* $NetBSD: kern_descrip.c,v 1.129 2005/01/14 00:25:12 cube Exp $ */
/*
* Copyright (c) 1982, 1986, 1989, 1991, 1993
@ -37,7 +37,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: kern_descrip.c,v 1.128 2005/01/12 20:41:45 cube Exp $");
__KERNEL_RCSID(0, "$NetBSD: kern_descrip.c,v 1.129 2005/01/14 00:25:12 cube Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@ -604,7 +604,7 @@ fdrelease(struct proc *p, int fd)
fdp = p->p_fd;
simple_lock(&fdp->fd_slock);
if ((u_int) fd > fdp->fd_lastfile)
if (fd < 0 || fd > fdp->fd_lastfile)
goto badf;
fpp = &fdp->fd_ofiles[fd];
fp = *fpp;