From f8310280bd3497fdeb2400fb1aad621ca0ff162e Mon Sep 17 00:00:00 2001 From: kamil Date: Mon, 17 Jun 2019 18:55:37 +0000 Subject: [PATCH] Introduce UBSAN_ALWAYS_FATAL in micro-UBSan UBSAN_ALWAYS_FATAL is a CPP option to mark all reports fatal always. --- common/lib/libc/misc/ubsan.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/common/lib/libc/misc/ubsan.c b/common/lib/libc/misc/ubsan.c index 24cfb5cba21f..42a76f0337da 100644 --- a/common/lib/libc/misc/ubsan.c +++ b/common/lib/libc/misc/ubsan.c @@ -1,4 +1,4 @@ -/* $NetBSD: ubsan.c,v 1.5 2019/02/13 17:17:02 kamil Exp $ */ +/* $NetBSD: ubsan.c,v 1.6 2019/06/17 18:55:37 kamil Exp $ */ /*- * Copyright (c) 2018 The NetBSD Foundation, Inc. @@ -38,9 +38,9 @@ #include #if defined(_KERNEL) -__KERNEL_RCSID(0, "$NetBSD: ubsan.c,v 1.5 2019/02/13 17:17:02 kamil Exp $"); +__KERNEL_RCSID(0, "$NetBSD: ubsan.c,v 1.6 2019/06/17 18:55:37 kamil Exp $"); #else -__RCSID("$NetBSD: ubsan.c,v 1.5 2019/02/13 17:17:02 kamil Exp $"); +__RCSID("$NetBSD: ubsan.c,v 1.6 2019/06/17 18:55:37 kamil Exp $"); #endif #if defined(_KERNEL) @@ -79,6 +79,12 @@ __RCSID("$NetBSD: ubsan.c,v 1.5 2019/02/13 17:17:02 kamil Exp $"); #define CLR(t, f) ((t) &= ~(f)) #endif +#ifdef UBSAN_ALWAYS_FATAL +static const bool alwaysFatal = true; +#else +static const bool alwaysFatal = false; +#endif + #define REINTERPRET_CAST(__dt, __st) ((__dt)(__st)) #define STATIC_CAST(__dt, __st) ((__dt)(__st)) @@ -1122,7 +1128,7 @@ Report(bool isFatal, const char *pFormat, ...) va_start(ap, pFormat); #if defined(_KERNEL) - if (isFatal) + if (isFatal || alwaysFatal) vpanic(pFormat, ap); else vprintf(pFormat, ap); @@ -1190,7 +1196,7 @@ Report(bool isFatal, const char *pFormat, ...) ubsan_vsyslog(LOG_DEBUG | LOG_USER, &SyslogData, pFormat, tmp); va_end(tmp); } - if (isFatal || ISSET(ubsan_flags, UBSAN_ABORT)) { + if (isFatal || alwaysFatal || ISSET(ubsan_flags, UBSAN_ABORT)) { abort(); __unreachable(); /* NOTREACHED */