Add an XXX comment so we don't forget what we need to do here:

* XXX: This is bogus. We should be failing the request
* XXX: not only if this specific slice is mounted, but
* XXX: if it's on a disk with any other mounted slice.
This commit is contained in:
elad 2006-11-26 17:21:25 +00:00
parent 1730a98675
commit f7fbd2e8b5
1 changed files with 7 additions and 2 deletions

View File

@ -1,4 +1,4 @@
/* $NetBSD: secmodel_bsd44_securelevel.c,v 1.16 2006/11/22 20:57:52 elad Exp $ */ /* $NetBSD: secmodel_bsd44_securelevel.c,v 1.17 2006/11/26 17:21:25 elad Exp $ */
/*- /*-
* Copyright (c) 2006 Elad Efrat <elad@NetBSD.org> * Copyright (c) 2006 Elad Efrat <elad@NetBSD.org>
* All rights reserved. * All rights reserved.
@ -38,7 +38,7 @@
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: secmodel_bsd44_securelevel.c,v 1.16 2006/11/22 20:57:52 elad Exp $"); __KERNEL_RCSID(0, "$NetBSD: secmodel_bsd44_securelevel.c,v 1.17 2006/11/26 17:21:25 elad Exp $");
#ifdef _KERNEL_OPT #ifdef _KERNEL_OPT
#include "opt_insecure.h" #include "opt_insecure.h"
@ -446,6 +446,11 @@ secmodel_bsd44_securelevel_device_cb(kauth_cred_t cred,
break; break;
} }
/*
* XXX: This is bogus. We should be failing the request
* XXX: not only if this specific slice is mounted, but
* XXX: if it's on a disk with any other mounted slice.
*/
if (vfs_mountedon(bvp) && (securelevel > 0)) if (vfs_mountedon(bvp) && (securelevel > 0))
break; break;