Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Make sure all routes through vt_curadr() range check the x and y coordinates.

Browse Source 
This fixes a nasty bug that could kill the kernel without ever reporting
a panic.
This commit is contained in:
mark 1996-07-05 19:07:55 +00:00
parent 8979b8342a
commit f5ee3d4ce6
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/arch/arm32/dev/console/vt220.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: vt220.c,v 1.7 1996/06/03 22:08:37 mark Exp $ */
/* $NetBSD: vt220.c,v 1.8 1996/07/05 19:07:55 mark Exp $ */
/*
* Copyright (c) 1994-1995 Melvyn Tang-Richardson
@ -329,6 +329,10 @@ strcpy ( console_proc, "vt_curadr" );
return;
}
/* Limit checking */
cdata->param[0] = (cdata->param[0] <= 0) ? 1 : cdata->param[0];
cdata->param[0] = (cdata->param[0] > vc->ychars) ? vc->ychars : cdata->param[0];
cdata->param[1] = (cdata->param[1] <= 0) ? 1 : cdata->param[1];
cdata->param[1] = (cdata->param[1] >= vc->xchars) ? (vc->xchars-1) : cdata->param[1];
(cdata->param[0])--;
(cdata->param[1])--;

6
sys/arch/arm32/vidc/console/vt220.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: vt220.c,v 1.7 1996/06/03 22:08:37 mark Exp $ */
/* $NetBSD: vt220.c,v 1.8 1996/07/05 19:07:55 mark Exp $ */
/*
* Copyright (c) 1994-1995 Melvyn Tang-Richardson
@ -329,6 +329,10 @@ strcpy ( console_proc, "vt_curadr" );
return;
}
/* Limit checking */
cdata->param[0] = (cdata->param[0] <= 0) ? 1 : cdata->param[0];
cdata->param[0] = (cdata->param[0] > vc->ychars) ? vc->ychars : cdata->param[0];
cdata->param[1] = (cdata->param[1] <= 0) ? 1 : cdata->param[1];
cdata->param[1] = (cdata->param[1] >= vc->xchars) ? (vc->xchars-1) : cdata->param[1];
(cdata->param[0])--;
(cdata->param[1])--;