Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't attempt to dereference an uninitialized 'ep' pointer if we can't

Browse Source 
make a temporary file to mail to the user.
Detected with gcc -Wuninitialized.
This commit is contained in:
lukem 2005-06-02 04:03:03 +00:00
parent 00cf2c1ca4
commit f01455eaa9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
usr.bin/vi/common/recover.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: recover.c,v 1.9 2005/01/19 01:20:24 mycroft Exp $ */ /* $NetBSD: recover.c,v 1.10 2005/06/02 04:03:03 lukem Exp $ */
/*- /*-
* Copyright (c) 1993, 1994 * Copyright (c) 1993, 1994
@ -16,7 +16,7 @@
#if 0 #if 0
static const char sccsid[] = "@(#)recover.c 10.21 (Berkeley) 9/15/96"; static const char sccsid[] = "@(#)recover.c 10.21 (Berkeley) 9/15/96";
#else #else
__RCSID("$NetBSD: recover.c,v 1.9 2005/01/19 01:20:24 mycroft Exp $"); __RCSID("$NetBSD: recover.c,v 1.10 2005/06/02 04:03:03 lukem Exp $");
#endif #endif
#endif /* not lint */ #endif /* not lint */
@ -360,6 +360,7 @@ rcv_mailfile(sp, issync, cp_path)
char host[MAXHOSTNAMELEN]; char host[MAXHOSTNAMELEN];
gp = sp->gp; gp = sp->gp;
ep = sp->ep;
if ((pw = getpwuid(uid = getuid())) == NULL) { if ((pw = getpwuid(uid = getuid())) == NULL) {
msgq(sp, M_ERR, msgq(sp, M_ERR,
"062|Information on user id %u not found", uid); "062|Information on user id %u not found", uid);
@ -381,7 +382,6 @@ rcv_mailfile(sp, issync, cp_path)
* be recovered. There's an obvious window between the mkstemp call * be recovered. There's an obvious window between the mkstemp call
* and the lock, but it's pretty small. * and the lock, but it's pretty small.
*/ */
ep = sp->ep;
if (file_lock(sp, NULL, NULL, fd, 1) != LOCK_SUCCESS) if (file_lock(sp, NULL, NULL, fd, 1) != LOCK_SUCCESS)
msgq(sp, M_SYSERR, "063|Unable to lock recovery file"); msgq(sp, M_SYSERR, "063|Unable to lock recovery file");
if (!issync) { if (!issync) {