Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

put the array bounds check _before_ accessing the array. 

Coverity  CID: 1480
This commit is contained in:
dmcmahill 2006-03-17 14:14:45 +00:00
parent 6ec9e1c359
commit ee00225705
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
usr.sbin/user/user.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: user.c,v 1.104 2006/02/23 22:45:25 christos Exp $ */ /* $NetBSD: user.c,v 1.105 2006/03/17 14:14:45 dmcmahill Exp $ */
/* /*
* Copyright (c) 1999 Alistair G. Crooks. All rights reserved. * Copyright (c) 1999 Alistair G. Crooks. All rights reserved.
@ -33,7 +33,7 @@
#ifndef lint #ifndef lint
__COPYRIGHT("@(#) Copyright (c) 1999 \ __COPYRIGHT("@(#) Copyright (c) 1999 \
The NetBSD Foundation, Inc. All rights reserved."); The NetBSD Foundation, Inc. All rights reserved.");
__RCSID("$NetBSD: user.c,v 1.104 2006/02/23 22:45:25 christos Exp $"); __RCSID("$NetBSD: user.c,v 1.105 2006/03/17 14:14:45 dmcmahill Exp $");
#endif #endif
#include <sys/types.h> #include <sys/types.h>
@ -1815,8 +1815,8 @@ useradd(int argc, char **argv)
memsave(&u.u_inactive, "-1", strlen("-1")); memsave(&u.u_inactive, "-1", strlen("-1"));
break; break;
case 'G': case 'G':
while ((u.u_groupv[u.u_groupc] = strsep(&optarg, ",")) != NULL && while (u.u_groupc < NGROUPS_MAX &&
u.u_groupc < NGROUPS_MAX) { (u.u_groupv[u.u_groupc] = strsep(&optarg, ",")) != NULL) {
if (u.u_groupv[u.u_groupc][0] != 0) { if (u.u_groupv[u.u_groupc][0] != 0) {
u.u_groupc++; u.u_groupc++;
} }