From eb7f9aba749d3f048dbc229beb0de48c8258f3e4 Mon Sep 17 00:00:00 2001 From: bouyer Date: Mon, 10 Apr 2006 22:01:06 +0000 Subject: [PATCH] Revert previous; I mixed bpp and *bpp when reading ffs_balloc_ufs1(). ffs_balloc() will always allocate a new buffer or leave it as NULL, so coverity is wrong here, we're not using a freed argument. --- sys/ufs/ffs/ffs_snapshot.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/sys/ufs/ffs/ffs_snapshot.c b/sys/ufs/ffs/ffs_snapshot.c index 3873625a2c65..0fbcea5da83c 100644 --- a/sys/ufs/ffs/ffs_snapshot.c +++ b/sys/ufs/ffs/ffs_snapshot.c @@ -1,4 +1,4 @@ -/* $NetBSD: ffs_snapshot.c,v 1.26 2006/04/10 21:50:18 bouyer Exp $ */ +/* $NetBSD: ffs_snapshot.c,v 1.27 2006/04/10 22:01:06 bouyer Exp $ */ /* * Copyright 2000 Marshall Kirk McKusick. All Rights Reserved. @@ -38,7 +38,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: ffs_snapshot.c,v 1.26 2006/04/10 21:50:18 bouyer Exp $"); +__KERNEL_RCSID(0, "$NetBSD: ffs_snapshot.c,v 1.27 2006/04/10 22:01:06 bouyer Exp $"); #if defined(_KERNEL_OPT) #include "opt_ffs.h" @@ -1539,10 +1539,8 @@ retry: * (default), or does not care about the block, * it is not needed. */ - if (lbn >= NDADDR) { + if (lbn >= NDADDR) brelse(ibp); - ibp = NULL; - } continue; } /*