Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

memcpy of overlapping arguments is UB. use memmove.

Browse Source 
CID 1299071

ok riastradh
This commit is contained in:
maya 2017-03-11 12:41:14 +00:00
parent e98f417cd2
commit e524e4b7aa
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/dev/usb/uhid.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: uhid.c,v 1.98 2016/07/07 06:55:42 msaitoh Exp $ */
/* $NetBSD: uhid.c,v 1.99 2017/03/11 12:41:14 maya Exp $ */
/*
* Copyright (c) 1998, 2004, 2008, 2012 The NetBSD Foundation, Inc.
@ -35,7 +35,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: uhid.c,v 1.98 2016/07/07 06:55:42 msaitoh Exp $");
__KERNEL_RCSID(0, "$NetBSD: uhid.c,v 1.99 2017/03/11 12:41:14 maya Exp $");
#ifdef _KERNEL_OPT
#include "opt_compat_netbsd.h"
@ -613,7 +613,7 @@ uhid_do_ioctl(struct uhid_softc *sc, u_long cmd, void *addr,
err = uhidev_get_report(&sc->sc_hdev, re->ucr_report,
re->ucr_data, size + extra);
if (extra)
memcpy(re->ucr_data, re->ucr_data+1, size);
memmove(re->ucr_data, re->ucr_data+1, size);
if (err)
return EIO;
break;