Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pool_do_cache_invalidate_grouplist: drop locks while calling the destructor. 

XXX Expensive - to be revisited.
This commit is contained in:
ad 2007-08-18 00:33:38 +00:00
parent ee1c78315b
commit e492e656cc
1 changed files with 29 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
sys/kern/subr_pool.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: subr_pool.c,v 1.129 2007/03/12 18:18:34 ad Exp $ */
/* $NetBSD: subr_pool.c,v 1.130 2007/08/18 00:33:38 ad Exp $ */
/*-
* Copyright (c) 1997, 1999, 2000, 2002 The NetBSD Foundation, Inc.
@ -38,7 +38,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: subr_pool.c,v 1.129 2007/03/12 18:18:34 ad Exp $");
__KERNEL_RCSID(0, "$NetBSD: subr_pool.c,v 1.130 2007/08/18 00:33:38 ad Exp $");
#include "opt_pool.h"
#include "opt_poollog.h"
@ -2184,26 +2184,43 @@ pool_cache_destruct_object(struct pool_cache *pc, void *object)
pool_put(pc->pc_pool, object);
}
/*
* pool_do_cache_invalidate_grouplist:
*
* Invalidate a single grouplist and destruct all objects.
* XXX This is too expensive. We should swap the list then
* unlock.
*/
static void
pool_do_cache_invalidate_grouplist(struct pool_cache_grouplist *pcgsl,
struct pool_cache *pc, struct pool_pagelist *pq,
struct pool_cache_grouplist *pcgdl)
{
struct pool_cache_group *pcg, *npcg;
struct pool_cache_group *pcg;
void *object;
for (pcg = LIST_FIRST(pcgsl); pcg != NULL; pcg = npcg) {
npcg = LIST_NEXT(pcg, pcg_list);
while (pcg->pcg_avail != 0) {
pc->pc_nitems--;
object = pcg_get(pcg, NULL);
if (pc->pc_dtor != NULL)
(*pc->pc_dtor)(pc->pc_arg, object);
pool_do_put(pc->pc_pool, object, pq);
}
LOCK_ASSERT(simple_lock_held(&pc->pc_slock));
LOCK_ASSERT(simple_lock_held(&pc->pc_pool->pr_slock));
while ((pcg = LIST_FIRST(pcgsl)) != NULL) {
pc->pc_ngroups--;
LIST_REMOVE(pcg, pcg_list);
LIST_INSERT_HEAD(pcgdl, pcg, pcg_list);
pc->pc_nitems -= pcg->pcg_avail;
simple_unlock(&pc->pc_pool->pr_slock);
simple_unlock(&pc->pc_slock);
while (pcg->pcg_avail != 0) {
object = pcg_get(pcg, NULL);
if (pc->pc_dtor != NULL)
(*pc->pc_dtor)(pc->pc_arg, object);
simple_lock(&pc->pc_pool->pr_slock);
pool_do_put(pc->pc_pool, object, pq);
simple_unlock(&pc->pc_pool->pr_slock);
}
simple_lock(&pc->pc_slock);
simple_lock(&pc->pc_pool->pr_slock);
}
}