Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

put the array bounds check _before_ accessing the array. 

Coverity  CID: 1479
This commit is contained in:
dmcmahill 2006-03-17 14:20:10 +00:00
parent ee00225705
commit de309be996
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
usr.sbin/user/user.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: user.c,v 1.105 2006/03/17 14:14:45 dmcmahill Exp $ */
/* $NetBSD: user.c,v 1.106 2006/03/17 14:20:10 dmcmahill Exp $ */
/*
* Copyright (c) 1999 Alistair G. Crooks. All rights reserved.
@ -33,7 +33,7 @@
#ifndef lint
__COPYRIGHT("@(#) Copyright (c) 1999 \
The NetBSD Foundation, Inc. All rights reserved.");
__RCSID("$NetBSD: user.c,v 1.105 2006/03/17 14:14:45 dmcmahill Exp $");
__RCSID("$NetBSD: user.c,v 1.106 2006/03/17 14:20:10 dmcmahill Exp $");
#endif
#include <sys/types.h>
@ -1955,9 +1955,9 @@ usermod(int argc, char **argv)
MOD_OPT_EXTENSIONS)) != -1) {
switch(c) {
case 'G':
while ((u.u_groupv[u.u_groupc] =
strsep(&optarg, ",")) != NULL &&
u.u_groupc < NGROUPS_MAX) {
while (u.u_groupc < NGROUPS_MAX &&
(u.u_groupv[u.u_groupc] =
strsep(&optarg, ",")) != NULL) {
if (u.u_groupv[u.u_groupc][0] != 0) {
u.u_groupc++;
}