Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Plug a slow kernel memory leak - a page was lost for each system or 

zombie process queried with the KERN_PROC_ARGS sysctl.  Fixed by moving
a malloc call after all possible early return conditions.
This commit is contained in:
simonb 2000-06-01 13:36:51 +00:00
parent 87a5ae384c
commit dbbe2b1dd7
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
sys/kern/kern_sysctl.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: kern_sysctl.c,v 1.66 2000/05/31 05:02:34 thorpej Exp $ */
/* $NetBSD: kern_sysctl.c,v 1.67 2000/06/01 13:36:51 simonb Exp $ */
/*-
* Copyright (c) 1982, 1986, 1989, 1993
@ -1374,10 +1374,6 @@ sysctl_procargs(name, namelen, where, sizep, up)
}
if (where == NULL || sizep == NULL)
return (EINVAL);
/*
* Allocate a temporary buffer to hold the arguments.
*/
arg = malloc(PAGE_SIZE, M_TEMP, M_WAITOK);
/*
* Zombies don't have a stack, so we can't read their psstrings.
@ -1395,6 +1391,11 @@ sysctl_procargs(name, namelen, where, sizep, up)
PHOLD(p);
p->p_vmspace->vm_refcnt++; /* XXX */
/*
* Allocate a temporary buffer to hold the arguments.
*/
arg = malloc(PAGE_SIZE, M_TEMP, M_WAITOK);
/*
* Read in the ps_strings structure.
*/