From d32ea5d5f28cac91c341fa21e7b92e3fd752e86d Mon Sep 17 00:00:00 2001 From: msaitoh Date: Tue, 11 Jun 2013 16:37:10 +0000 Subject: [PATCH] Remove an extra mii_pollstat() call. The PHY status should be updated by adjacent mii_tick() call. I suspect that this mii_pollstat() call was added to do workaround for broken MII_TICK code. A lot of MII PHY drivers had bugs in MII_TICK and those bugs were fixed. --- sys/dev/pci/if_sk.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/sys/dev/pci/if_sk.c b/sys/dev/pci/if_sk.c index ebf5e01ab579..d33176a88744 100644 --- a/sys/dev/pci/if_sk.c +++ b/sys/dev/pci/if_sk.c @@ -1,4 +1,4 @@ -/* $NetBSD: if_sk.c,v 1.73 2013/03/30 03:21:07 christos Exp $ */ +/* $NetBSD: if_sk.c,v 1.74 2013/06/11 16:37:10 msaitoh Exp $ */ /*- * Copyright (c) 2003 The NetBSD Foundation, Inc. @@ -115,7 +115,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: if_sk.c,v 1.73 2013/03/30 03:21:07 christos Exp $"); +__KERNEL_RCSID(0, "$NetBSD: if_sk.c,v 1.74 2013/06/11 16:37:10 msaitoh Exp $"); #include #include @@ -2219,7 +2219,6 @@ sk_tick(void *xsc_if) SK_XM_CLRBIT_2(sc_if, XM_IMR, XM_IMR_GP0_SET); SK_XM_READ_2(sc_if, XM_ISR); mii_tick(mii); - mii_pollstat(mii); callout_stop(&sc_if->sk_tick_ch); }