Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Coverity CID 2501: Make it painfully obvious that memh is initialized.

This commit is contained in:
christos 2006-04-14 21:12:00 +00:00
parent a5fe7389ec
commit c56f241b01
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/dev/ic/tcic2.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: tcic2.c,v 1.23 2005/12/11 12:21:28 christos Exp $ */
/* $NetBSD: tcic2.c,v 1.24 2006/04/14 21:12:00 christos Exp $ */
/*
* Copyright (c) 1998, 1999 Christoph Badura. All rights reserved.
@ -31,7 +31,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: tcic2.c,v 1.23 2005/12/11 12:21:28 christos Exp $");
__KERNEL_RCSID(0, "$NetBSD: tcic2.c,v 1.24 2006/04/14 21:12:00 christos Exp $");
#undef TCICDEBUG
@ -743,7 +743,7 @@ tcic_chip_mem_alloc(pch, size, pcmhp)
bus_space_handle_t memh;
bus_addr_t addr;
bus_size_t sizepg;
int i, mask, mhandle;
int i, mask, mhandle, got = 0;
/* out of sc->memh, allocate as many pages as necessary */
@ -777,11 +777,12 @@ tcic_chip_mem_alloc(pch, size, pcmhp)
mhandle = mask << i;
addr = h->sc->membase + (i * TCIC_MEM_PAGESIZE);
h->sc->subregionmask &= ~(mhandle);
got = 1;
break;
}
}
if (i == (TCIC_MEM_PAGES + 1 - sizepg))
if (got == 0)
return (1);
DPRINTF(("tcic_chip_mem_alloc bus addr 0x%lx+0x%lx\n", (u_long) addr,