Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

run_rc_command - don't prefix the rcvar variable name with the dollar sign.

Browse Source 
The output without the dollar sign is less confusing as it's actual
valid shell syntax:

  $ /etc/rc.d/foo rcvar
  # food
  food=YES

Brought up on tech-userlevel@ by Rocky Hotas with some LGTMs from
other people and no objections.

We still refer to '$food' in warnings/errors though.
This commit is contained in:
uwe 2020-12-20 21:30:28 +00:00
parent 5196cc55b0
commit c34ee3711d
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
etc/rc.subr
View File

@ -1,4 +1,4 @@
# $NetBSD: rc.subr,v 1.105 2020/09/17 20:29:03 otis Exp $ # $NetBSD: rc.subr,v 1.106 2020/12/20 21:30:28 uwe Exp $
# #
# Copyright (c) 1997-2011 The NetBSD Foundation, Inc. # Copyright (c) 1997-2011 The NetBSD Foundation, Inc.
# All rights reserved. # All rights reserved.
@ -822,9 +822,9 @@ $command $rc_flags $command_args"
echo "# $name" echo "# $name"
if [ -n "$rcvar" ]; then if [ -n "$rcvar" ]; then
if checkyesno ${rcvar}; then if checkyesno ${rcvar}; then
echo "\$${rcvar}=YES" echo "${rcvar}=YES"
else else
echo "\$${rcvar}=NO" echo "${rcvar}=NO"
fi fi
fi fi
;; ;;