From c066baf306a2c4be9c1ce6e4582cc3e4f1cbfaad Mon Sep 17 00:00:00 2001 From: rillig Date: Mon, 15 Mar 2021 16:45:30 +0000 Subject: [PATCH] make: fix documentation of Lst_MoveAll In CLEANUP mode, was originally meant to track memory allocations but is useful during debugging as well, initialize the list. There is no distinct constant representing an invalid pointer, otherwise that would have been an even better choice. --- usr.bin/make/lst.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/usr.bin/make/lst.c b/usr.bin/make/lst.c index 8f3c32ef72e6..372973112783 100644 --- a/usr.bin/make/lst.c +++ b/usr.bin/make/lst.c @@ -1,4 +1,4 @@ -/* $NetBSD: lst.c,v 1.104 2021/02/01 19:39:31 rillig Exp $ */ +/* $NetBSD: lst.c,v 1.105 2021/03/15 16:45:30 rillig Exp $ */ /* * Copyright (c) 1988, 1989, 1990, 1993 @@ -34,7 +34,7 @@ #include "make.h" -MAKE_RCSID("$NetBSD: lst.c,v 1.104 2021/02/01 19:39:31 rillig Exp $"); +MAKE_RCSID("$NetBSD: lst.c,v 1.105 2021/03/15 16:45:30 rillig Exp $"); static ListNode * LstNodeNew(ListNode *prev, ListNode *next, void *datum) @@ -205,7 +205,7 @@ Lst_FindDatum(List *list, const void *datum) /* * Move all nodes from src to the end of dst. - * The source list becomes empty but is not freed. + * The source list becomes indeterminate. */ void Lst_MoveAll(List *dst, List *src) @@ -219,6 +219,10 @@ Lst_MoveAll(List *dst, List *src) dst->last = src->last; } +#ifdef CLEANUP + src->first = NULL; + src->last = NULL; +#endif } /* Copy the element data from src to the start of dst. */