Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pmap_destroy: cast return of atomic_dec_uint_nv to (int) to avoid leaking

Browse Source 
pmaps. The refcount can be zero due to pmap_remove_all. Problem found by
tnn@.
This commit is contained in:
ad 2008-01-08 00:45:23 +00:00
parent 72b3924d8b
commit c0187a5323
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sys/arch/sparc64/sparc64/pmap.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: pmap.c,v 1.207 2008/01/06 18:24:06 martin Exp $ */
/* $NetBSD: pmap.c,v 1.208 2008/01/08 00:45:23 ad Exp $ */
/*
*
* Copyright (C) 1996-1999 Eduardo Horvath.
@ -26,7 +26,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: pmap.c,v 1.207 2008/01/06 18:24:06 martin Exp $");
__KERNEL_RCSID(0, "$NetBSD: pmap.c,v 1.208 2008/01/08 00:45:23 ad Exp $");
#undef NO_VCACHE /* Don't forget the locked TLB in dostart */
#define HWREF
@ -1293,7 +1293,7 @@ pmap_destroy(pm)
{
struct vm_page *pg, *nextpg;
if (atomic_dec_uint_nv(&pm->pm_refs) > 0) {
if ((int)atomic_dec_uint_nv(&pm->pm_refs) > 0) {
return;
}
DPRINTF(PDB_DESTROY, ("pmap_destroy: freeing pmap %p\n", pm));