Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ext_ops does not change during the life cycle and can be fetched without 

the mutex held. This avoids confusion in the compiler about an uninitialized
variable ext_ops.
ok rmind@
This commit is contained in:
mlelstv 2012-10-03 12:24:56 +00:00
parent 582d3a41a2
commit b7abe5ff3b
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/net/npf/npf_rproc.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: npf_rproc.c,v 1.3 2012/09/16 13:47:41 rmind Exp $ */
/* $NetBSD: npf_rproc.c,v 1.4 2012/10/03 12:24:56 mlelstv Exp $ */
/*-
* Copyright (c) 2009-2012 The NetBSD Foundation, Inc.
@ -164,14 +164,16 @@ npf_ext_construct(const char *name, npf_rproc_t *rp, prop_dictionary_t params)
ext = npf_ext_lookup(name);
if (ext) {
atomic_inc_uint(&ext->ext_refcnt);
extops = ext->ext_ops;
KASSERT(extops != NULL);
}
mutex_exit(&ext_lock);
if (!ext) {
return ENOENT;
}
extops = ext->ext_ops;
KASSERT(extops != NULL);
error = extops->ctor(rp, params);
if (error) {
atomic_dec_uint(&ext->ext_refcnt);