Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

If getpwuid() returns null, its not usually a good idea to dereference

Browse Source 
that to try to assign a default value. Just copy the default value into
the final destination.
Addresses Coverty CID 925
This commit is contained in:
abs 2006-03-17 23:11:47 +00:00
parent c3e43200eb
commit b317f83344
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
games/robots/score.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: score.c,v 1.17 2004/01/27 20:30:30 jsm Exp $ */ /* $NetBSD: score.c,v 1.18 2006/03/17 23:11:47 abs Exp $ */
/* /*
* Copyright (c) 1980, 1993 * Copyright (c) 1980, 1993
@ -34,7 +34,7 @@
#if 0 #if 0
static char sccsid[] = "@(#)score.c 8.1 (Berkeley) 5/31/93"; static char sccsid[] = "@(#)score.c 8.1 (Berkeley) 5/31/93";
#else #else
__RCSID("$NetBSD: score.c,v 1.17 2004/01/27 20:30:30 jsm Exp $"); __RCSID("$NetBSD: score.c,v 1.18 2006/03/17 23:11:47 abs Exp $");
#endif #endif
#endif /* not lint */ #endif /* not lint */
@ -193,10 +193,10 @@ set_name(scp)
SCORE *scp; SCORE *scp;
{ {
PASSWD *pp; PASSWD *pp;
static char unknown[] = "???";
if ((pp = getpwuid(scp->s_uid)) == NULL) if ((pp = getpwuid(scp->s_uid)) == NULL)
pp->pw_name = unknown; strncpy(scp->s_name, "???", MAXNAME);
else
strncpy(scp->s_name, pp->pw_name, MAXNAME); strncpy(scp->s_name, pp->pw_name, MAXNAME);
} }