From a97560b6443382e82fd5f94e9bc73592eafbcfea Mon Sep 17 00:00:00 2001 From: joerg Date: Tue, 7 Jan 2014 02:07:43 +0000 Subject: [PATCH] Annotate logit to provide transitive format string checks. --- lib/libpam/modules/pam_lastlog/pam_lastlog.c | 5 +++-- lib/libpam/modules/pam_login_access/login_access.c | 5 +++-- lib/libpam/modules/pam_radius/pam_radius.c | 5 +++-- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/libpam/modules/pam_lastlog/pam_lastlog.c b/lib/libpam/modules/pam_lastlog/pam_lastlog.c index 3a9be17ba434..5e41c8de4bd0 100644 --- a/lib/libpam/modules/pam_lastlog/pam_lastlog.c +++ b/lib/libpam/modules/pam_lastlog/pam_lastlog.c @@ -1,4 +1,4 @@ -/* $NetBSD: pam_lastlog.c,v 1.14 2012/01/03 19:02:55 christos Exp $ */ +/* $NetBSD: pam_lastlog.c,v 1.15 2014/01/07 02:07:43 joerg Exp $ */ /*- * Copyright (c) 1980, 1987, 1988, 1991, 1993, 1994 @@ -47,7 +47,7 @@ #ifdef __FreeBSD__ __FBSDID("$FreeBSD: src/lib/libpam/modules/pam_lastlog/pam_lastlog.c,v 1.20 2004/01/26 19:28:37 des Exp $"); #else -__RCSID("$NetBSD: pam_lastlog.c,v 1.14 2012/01/03 19:02:55 christos Exp $"); +__RCSID("$NetBSD: pam_lastlog.c,v 1.15 2014/01/07 02:07:43 joerg Exp $"); #endif #include @@ -95,6 +95,7 @@ static void domsg(pam_handle_t *, time_t, const char *, size_t, const char *, size_t); #endif +__printflike(2, 3) static void logit(int level, const char *fmt, ...) { diff --git a/lib/libpam/modules/pam_login_access/login_access.c b/lib/libpam/modules/pam_login_access/login_access.c index 08cc57f4dfc0..c4a8972741ee 100644 --- a/lib/libpam/modules/pam_login_access/login_access.c +++ b/lib/libpam/modules/pam_login_access/login_access.c @@ -1,4 +1,4 @@ -/* $NetBSD: login_access.c,v 1.7 2013/12/29 22:54:58 christos Exp $ */ +/* $NetBSD: login_access.c,v 1.8 2014/01/07 02:07:43 joerg Exp $ */ /* * This module implements a simple but effective form of login access @@ -19,7 +19,7 @@ static char sccsid[] = "%Z% %M% %I% %E% %U%"; #ifdef __FreeBSD__ __FBSDID("$FreeBSD: src/lib/libpam/modules/pam_login_access/login_access.c,v 1.12 2004/03/05 08:10:18 markm Exp $"); #else -__RCSID("$NetBSD: login_access.c,v 1.7 2013/12/29 22:54:58 christos Exp $"); +__RCSID("$NetBSD: login_access.c,v 1.8 2014/01/07 02:07:43 joerg Exp $"); #endif #include @@ -56,6 +56,7 @@ static int user_match(const char *, const char *); /* login_access - match username/group and host/tty with access control file */ +__printflike(2, 3) static void logit(int level, const char *fmt, ...) { diff --git a/lib/libpam/modules/pam_radius/pam_radius.c b/lib/libpam/modules/pam_radius/pam_radius.c index 30b2597254ff..557a7a43696c 100644 --- a/lib/libpam/modules/pam_radius/pam_radius.c +++ b/lib/libpam/modules/pam_radius/pam_radius.c @@ -1,4 +1,4 @@ -/* $NetBSD: pam_radius.c,v 1.7 2006/11/03 18:55:40 christos Exp $ */ +/* $NetBSD: pam_radius.c,v 1.8 2014/01/07 02:07:43 joerg Exp $ */ /*- * Copyright 1998 Juniper Networks, Inc. @@ -40,7 +40,7 @@ #ifdef __FreeBSD__ __FBSDID("$FreeBSD: src/lib/libpam/modules/pam_radius/pam_radius.c,v 1.22 2004/06/25 12:32:45 kan Exp $"); #else -__RCSID("$NetBSD: pam_radius.c,v 1.7 2006/11/03 18:55:40 christos Exp $"); +__RCSID("$NetBSD: pam_radius.c,v 1.8 2014/01/07 02:07:43 joerg Exp $"); #endif #include @@ -76,6 +76,7 @@ static int do_accept(pam_handle_t *, struct rad_handle *); static int do_challenge(pam_handle_t *, struct rad_handle *, const char *); +__printflike(2, 3) static void logit(int level, const char *fmt, ...) {