Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

The decision that `disksort_cylinder' uses to decide if the buffer needs 

to go to the inversion list is incomplete. If the cylinders are equal
block numbers must be checked.

This caused lockups if some buffers with the same cylinder were cycling
through the list, as it may happen with softdep enabled.

Fixes PR #9197.
This commit is contained in:
hannken 2000-01-28 09:27:38 +00:00
parent 59b810d3a5
commit a6ee792cee
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/kern/subr_disk.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: subr_disk.c,v 1.26 2000/01/21 23:20:51 thorpej Exp $ */
/* $NetBSD: subr_disk.c,v 1.27 2000/01/28 09:27:38 hannken Exp $ */
/*-
* Copyright (c) 1996, 1997, 1999, 2000 The NetBSD Foundation, Inc.
@ -139,7 +139,8 @@ disksort_cylinder(bufq, bp)
* If we lie after the first (currently active) request, then we
* must locate the second request list and add ourselves to it.
*/
if (bp->b_cylinder < bq->b_cylinder) {
if (bp->b_cylinder < bq->b_cylinder ||
(bp->b_cylinder == bq->b_cylinder && bp->b_blkno < bq->b_blkno)) {
while ((nbq = BUFQ_NEXT(bq)) != NULL) {
/*
* Check for an ``inversion'' in the normally ascending