Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix a very old and annoying bug: Adding suffixes to sufflist wasn't setting 

a refCount of 1 to indicate its presence on sufflist.  Hence suffixes were
being removed by Suff_EndTransform() and being freed before all the
referential links were removed.  This resulted in a malloc warning on 1.5.x:
  make in free(): warning: chunk is already free.

This could be reproduced with the following simple Makefile passed to
"make -r":
=====
.SUFFIXES: .l .c
.l.c:
foo:
This commit is contained in:
tv 2001-11-14 19:27:40 +00:00
parent 66a8284d66
commit a4c4ea7686
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
usr.bin/make/suff.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: suff.c,v 1.34 2001/08/20 12:00:55 wiz Exp $ */
/* $NetBSD: suff.c,v 1.35 2001/11/14 19:27:40 tv Exp $ */
/*
* Copyright (c) 1988, 1989, 1990, 1993
@ -39,14 +39,14 @@
*/
#ifdef MAKE_BOOTSTRAP
static char rcsid[] = "$NetBSD: suff.c,v 1.34 2001/08/20 12:00:55 wiz Exp $";
static char rcsid[] = "$NetBSD: suff.c,v 1.35 2001/11/14 19:27:40 tv Exp $";
#else
#include <sys/cdefs.h>
#ifndef lint
#if 0
static char sccsid[] = "@(#)suff.c 8.4 (Berkeley) 3/21/94";
#else
__RCSID("$NetBSD: suff.c,v 1.34 2001/08/20 12:00:55 wiz Exp $");
__RCSID("$NetBSD: suff.c,v 1.35 2001/11/14 19:27:40 tv Exp $");
#endif
#endif /* not lint */
#endif
@ -928,7 +928,7 @@ Suff_AddSuffix (str, gn)
s->ref = Lst_Init (FALSE);
s->sNum = sNum++;
s->flags = 0;
s->refCount = 0;
s->refCount = 1;
(void)Lst_AtEnd (sufflist, (ClientData)s);
/*