From a3a0bab7f9983bf31a23c4432650e7edc4db9018 Mon Sep 17 00:00:00 2001 From: njoly Date: Thu, 15 Mar 2012 12:57:27 +0000 Subject: [PATCH] Add another testcase that check setting file times with unprivileged credentials. --- tests/fs/vfs/t_unpriv.c | 35 ++++++++++++++++++++++++++++++++++- 1 file changed, 34 insertions(+), 1 deletion(-) diff --git a/tests/fs/vfs/t_unpriv.c b/tests/fs/vfs/t_unpriv.c index 98f92992780e..0a1632a25e65 100644 --- a/tests/fs/vfs/t_unpriv.c +++ b/tests/fs/vfs/t_unpriv.c @@ -1,4 +1,4 @@ -/* $NetBSD: t_unpriv.c,v 1.5 2012/02/09 18:31:03 njoly Exp $ */ +/* $NetBSD: t_unpriv.c,v 1.6 2012/03/15 12:57:27 njoly Exp $ */ /*- * Copyright (c) 2011 The NetBSD Foundation, Inc. @@ -26,6 +26,8 @@ * POSSIBILITY OF SUCH DAMAGE. */ +#include + #include #include #include @@ -115,14 +117,45 @@ dirperms(const atf_tc_t *tc, const char *mp) FSTEST_EXIT(); } +static void +times(const atf_tc_t *tc, const char *mp) +{ + const char *name = "file.test"; + int fd; + + FSTEST_ENTER(); + + if ((fd = rump_sys_open(name, O_RDWR|O_CREAT, 0666)) == -1) + atf_tc_fail_errno("open"); + if (rump_sys_close(fd) == -1) + atf_tc_fail_errno("close"); + + rump_pub_lwproc_rfork(RUMP_RFCFDG); + if (rump_sys_setuid(1) == -1) + atf_tc_fail_errno("setuid"); + if (rump_sys_utimes(name, NULL) != -1 || errno != EACCES) + atf_tc_fail_errno("utimes"); + rump_pub_lwproc_releaselwp(); + + if (rump_sys_utimes(name, NULL) == -1) + atf_tc_fail_errno("utimes"); + + if (rump_sys_unlink(name) == -1) + atf_tc_fail_errno("unlink"); + + FSTEST_EXIT(); +} + ATF_TC_FSAPPLY(owner, "owner unprivileged checks"); ATF_TC_FSAPPLY(dirperms, "directory permission checks"); +ATF_TC_FSAPPLY(times, "time set checks"); ATF_TP_ADD_TCS(tp) { ATF_TP_FSAPPLY(owner); ATF_TP_FSAPPLY(dirperms); + ATF_TP_FSAPPLY(times); return atf_no_error(); }