Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Drop connections to the broadcast address. From BUGTRAQ. This is a security

Browse Source 
issue because it can by-pass ipf rules unintentionally.
This commit is contained in:
christos 2002-03-19 14:35:20 +00:00
parent 3d000fd59c
commit 9c8babbd46
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
sys/netinet/tcp_input.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: tcp_input.c,v 1.136 2002/03/12 04:36:47 itojun Exp $ */
/* $NetBSD: tcp_input.c,v 1.137 2002/03/19 14:35:20 christos Exp $ */
/*
* Copyright (C) 1995, 1996, 1997, and 1998 WIDE Project.
@ -152,7 +152,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: tcp_input.c,v 1.136 2002/03/12 04:36:47 itojun Exp $");
__KERNEL_RCSID(0, "$NetBSD: tcp_input.c,v 1.137 2002/03/19 14:35:20 christos Exp $");
#include "opt_inet.h"
#include "opt_ipsec.h"
@ -700,7 +700,9 @@ tcp_input(m, va_alist)
* Make sure destination address is not multicast.
* Source address checked in ip_input().
*/
if (IN_MULTICAST(ip->ip_dst.s_addr)) {
if (IN_MULTICAST(ip->ip_dst.s_addr) ||
in_broadcast(ip->ip_dst, m->m_pkthdr.rcvif)) {
/* XXX stat */
goto drop;
}
@ -2247,6 +2249,11 @@ dropwithreset:
*/
if (tiflags & TH_RST)
goto drop;
if (IN_MULTICAST(ip->ip_dst.s_addr) ||
in_broadcast(ip->ip_dst, m->m_pkthdr.rcvif))
goto drop;
{
/*
* need to recover version # field, which was overwritten on