Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use the same iterator in a nested loop. (How could this work?) 

Found by the lgtm bot.
This commit is contained in:
maxv 2019-09-20 11:29:47 +00:00
parent 0fd1f118ce
commit 9baf3ad469
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/dev/ic/an.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: an.c,v 1.70 2019/02/05 06:17:02 msaitoh Exp $ */
/* $NetBSD: an.c,v 1.71 2019/09/20 11:29:47 maxv Exp $ */
/*
* Copyright (c) 1997, 1998, 1999
* Bill Paul <wpaul@ctr.columbia.edu>. All rights reserved.
@ -77,7 +77,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: an.c,v 1.70 2019/02/05 06:17:02 msaitoh Exp $");
__KERNEL_RCSID(0, "$NetBSD: an.c,v 1.71 2019/09/20 11:29:47 maxv Exp $");
#include <sys/param.h>
@ -1240,8 +1240,9 @@ an_set_nwkey_eap(struct an_softc *sc, struct ieee80211_nwkey *nwkey)
*/
memset(unibuf, 0, sizeof(unibuf));
/* XXX: convert password to unicode */
for (i = 0; i < len; i++)
unibuf[i] = key->an_key[i];
int j;
for (j = 0; j < len; j++)
unibuf[j] = key->an_key[j];
/* set PasswordHash */
MD4Init(&ctx);
MD4Update(&ctx, (u_int8_t *)unibuf, len * 2);