Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make: do not evaluate the ':O' modifiers in parse-only mode

Browse Source 
No functional change in practical usage.  Theoretically this change can
be observed by looking at the generated random numbers for the ':Ox'
modifier, but the quality or exact sequence of these random numbers is
not guaranteed anyway.
This commit is contained in:
rillig 2021-03-14 20:03:56 +00:00
parent f7a4d3a3e0
commit 96faeb06ee
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
usr.bin/make/var.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: var.c,v 1.878 2021/03/14 20:00:48 rillig Exp $ */
/* $NetBSD: var.c,v 1.879 2021/03/14 20:03:56 rillig Exp $ */
/*
* Copyright (c) 1988, 1989, 1990, 1993
@ -140,7 +140,7 @@
#include "metachar.h"
/* "@(#)var.c 8.3 (Berkeley) 3/19/94" */
MAKE_RCSID("$NetBSD: var.c,v 1.878 2021/03/14 20:00:48 rillig Exp $");
MAKE_RCSID("$NetBSD: var.c,v 1.879 2021/03/14 20:03:56 rillig Exp $");
typedef enum VarFlags {
VFL_NONE = 0,
@ -3275,6 +3275,9 @@ ApplyModifier_Order(const char **pp, ApplyModifiersState *st)
} else
return AMR_BAD;
if (!(st->expr->eflags & VARE_WANTRES))
return AMR_OK;
words = Str_Words(st->expr->value.str, FALSE);
if (mode == SHUFFLE)
ShuffleStrings(words.words, words.len);