Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Address the remaining Coverity problems from Mark D. Baushke

Browse Source
This commit is contained in:
christos 2006-05-11 17:47:49 +00:00
parent b1e7b0cf85
commit 90463da1f9
7 changed files with 86 additions and 31 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
gnu/dist/xcvs/ChangeLog vendored
View File

@ -1,3 +1,53 @@
2006-05-11 Mark D. Baushke <mdb@gnu.org>
* add.c (add_directory): Protect tag from NULL dereference.
[Fixes NetBSD cid-1054.]
* client.c (handle_mt): Deal with missing text argument.
[Fixes NetBSD cid-924.]
* entries.c (Entnode_Create): Protect date, tag and ts_conflict
from possible NULL dereference.
[Fixes NetBSD coverity cid-994, cid-995, cid-1055, cid-1057.]
* entries.c (Entries_Open): Protect dirtag and dirdate from
possible NULL dereference.
[Fixes NetBSD coverity cid-996.]
* log.c (cvslog): Validate start and end args to
date_to_internet().
[Fixes NetBSD coverity cid-2427 and cid-2428.]
* logmsg.c (fmt_proc): Protect li->tag from NULL dereference.
[Fixes NetBSD coverity cid-997.]
* vers_ts.c (Version_TS): Protect tag and vers_ts->tag from NULL
dereference.
[Fixes NetBSD coverity cid-1053.]
2006-05-04 Mark D. Baushke <mdb@gnu.org>
* filesubr.c (cvs_temp_file): Avoid keeping pointers to free()'d
storage laying around.
* commit.c (commit): Handle possible NULL filename values
returned from cvs_temp_file().
* filesubr.c (cvs_temp_name): Ditto.
* import.c (import): Ditto.
* login.c (password_entry_operation): Ditto.
* logmsg.c (do_verify): Ditto.
* patch.c (patch_fileproc): Ditto.
[Fixes NetBSD coverity cid-2545.]
* buffer.c (packetizing_buffer_output): Initialize outdata.
[Fixes NetBSD coverity cid-2474.]
* server.c (server_updated): Fix NetBSD coverity cid-1352
NetBSD-sparc64 of 2006-May-02 03:02:46.
2005-09-26 Conrad T. Pino <Conrad@Pino.com>
* rcs.c: Use "#ifdef HAVE_FSYNC" just like every where else.
2005-09-26 Derek Price <derek@ximbiot.com>
[bug #14639]

2
gnu/dist/xcvs/src/add.c vendored
View File

@ -852,7 +852,7 @@ add_directory (finfo)
p->key = xstrdup ("- New directory");
li = (struct logfile_info *) xmalloc (sizeof (struct logfile_info));
li->type = T_TITLE;
li->tag = xstrdup (tag);
li->tag = tag ? xstrdup (tag) : NULL;
li->rev_old = li->rev_new = NULL;
p->data = li;
(void) addnode (ulist, p);

10
gnu/dist/xcvs/src/client.c vendored
View File

@ -3277,7 +3277,7 @@ handle_mt (args, len)
cvs_output ("\n", 1);
free (updated_fname);
}
updated_fname = xstrdup (text);
updated_fname = text ? xstrdup (text) : NULL;
}
/* Swallow all other tags. Either they are extraneous
or they reflect future extensions that we can
@ -3286,13 +3286,13 @@ handle_mt (args, len)
else if (importmergecmd.seen)
{
if (strcmp (tag, "conflicts") == 0)
importmergecmd.conflicts = atoi (text);
importmergecmd.conflicts = text ? atoi (text) : -1;
else if (strcmp (tag, "mergetag1") == 0)
importmergecmd.mergetag1 = xstrdup (text);
importmergecmd.mergetag1 = text ? xstrdup (text) : NULL;
else if (strcmp (tag, "mergetag2") == 0)
importmergecmd.mergetag2 = xstrdup (text);
importmergecmd.mergetag2 = text ? xstrdup (text) : NULL;
else if (strcmp (tag, "repository") == 0)
importmergecmd.repository = xstrdup (text);
importmergecmd.repository = text ? xstrdup (text) : NULL;
/* Swallow all other tags. Either they are text for
which we are going to print our own version when we
see -importmergecmd, or they are future extensions

10
gnu/dist/xcvs/src/entries.c vendored
View File

@ -59,9 +59,9 @@ Entnode_Create(type, user, vn, ts, options, tag, date, ts_conflict)
ent->version = xstrdup (vn);
ent->timestamp = xstrdup (ts ? ts : "");
ent->options = xstrdup (options ? options : "");
ent->tag = xstrdup (tag);
ent->date = xstrdup (date);
ent->conflict = xstrdup (ts_conflict);
ent->tag = tag ? xstrdup (tag) : NULL;
ent->date = date ? xstrdup (date) : NULL;
ent->conflict = ts_conflict ? xstrdup (ts_conflict) : NULL;
return ent;
}
@ -491,8 +491,8 @@ Entries_Open (aflag, update_dir)
sdtp = (struct stickydirtag *) xmalloc (sizeof (*sdtp));
memset ((char *) sdtp, 0, sizeof (*sdtp));
sdtp->aflag = aflag;
sdtp->tag = xstrdup (dirtag);
sdtp->date = xstrdup (dirdate);
sdtp->tag = dirtag ? xstrdup (dirtag) : NULL;
sdtp->date = dirdate ? xstrdup (dirdate) : NULL;
sdtp->nonbranch = dirnonbranch;
/* feed it into the list-private area */

37
gnu/dist/xcvs/src/log.c vendored
View File

@ -316,17 +316,20 @@ cvslog (argc, argv)
{
p = log_data.datelist;
log_data.datelist = p->next;
send_to_server ("Argument -d\012", 0);
send_to_server ("Argument ", 0);
date_to_internet (datetmp, p->start);
send_to_server (datetmp, 0);
if (p->inclusive)
send_to_server ("<=", 0);
else
send_to_server ("<", 0);
date_to_internet (datetmp, p->end);
send_to_server (datetmp, 0);
send_to_server ("\012", 0);
if (p->start != NULL && p->end != NULL)
{
send_to_server ("Argument -d\012", 0);
send_to_server ("Argument ", 0);
date_to_internet (datetmp, p->start);
send_to_server (datetmp, 0);
if (p->inclusive)
send_to_server ("<=", 0);
else
send_to_server ("<", 0);
date_to_internet (datetmp, p->end);
send_to_server (datetmp, 0);
send_to_server ("\012", 0);
}
if (p->start)
free (p->start);
if (p->end)
@ -337,13 +340,15 @@ cvslog (argc, argv)
{
p = log_data.singledatelist;
log_data.singledatelist = p->next;
send_to_server ("Argument -d\012", 0);
send_to_server ("Argument ", 0);
date_to_internet (datetmp, p->end);
send_to_server (datetmp, 0);
send_to_server ("\012", 0);
if (p->end)
{
send_to_server ("Argument -d\012", 0);
send_to_server ("Argument ", 0);
date_to_internet (datetmp, p->end);
send_to_server (datetmp, 0);
send_to_server ("\012", 0);
free (p->end);
}
free (p);
}

2
gnu/dist/xcvs/src/logmsg.c vendored
View File

@ -155,7 +155,7 @@ fmt_proc (p, closure)
if (tag != NULL)
free (tag);
tag = xstrdup (li->tag);
tag = li->tag ? xstrdup (li->tag) : NULL;
/* Force a new line. */
col = 70;

6
gnu/dist/xcvs/src/vers_ts.c vendored
View File

@ -155,8 +155,8 @@ Version_TS (finfo, options, tag, date, force_tag_match, set_time)
*/
if (tag || date)
{
vers_ts->tag = xstrdup (tag);
vers_ts->date = xstrdup (date);
vers_ts->tag = tag ? xstrdup (tag) : NULL;
vers_ts->date = date ? xstrdup (date) : NULL;
}
else if (!vers_ts->entdata && (sdtp && sdtp->aflag == 0))
{
@ -200,7 +200,7 @@ Version_TS (finfo, options, tag, date, force_tag_match, set_time)
if (vers_ts->vn_rcs == NULL)
vers_ts->vn_tag = NULL;
else if (simple)
vers_ts->vn_tag = xstrdup (vers_ts->tag);
vers_ts->vn_tag = vers_ts->tag ? xstrdup (vers_ts->tag) : NULL;
else
vers_ts->vn_tag = xstrdup (vers_ts->vn_rcs);
}