Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use bounded string op (snprintf instead of sprintf) for an automatic 

array which is used to calculate the maximum width of a scroll entry
item.  Previous use of sprintf would blindly overwrite the stack if
there were more than 100 characters in an entry item.
This commit is contained in:
agc 2003-08-28 11:32:33 +00:00
parent aae64118ef
commit 8fcc4625a4
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
dist/cdk/scroll.c vendored
View File

@ -1,9 +1,9 @@
#include <cdk.h>
/*
* $Author: garbled $
* $Date: 2001/01/09 18:41:54 $
* $Revision: 1.3 $
* $Author: agc $
* $Date: 2003/08/28 11:32:33 $
* $Revision: 1.4 $
*/
/*
@ -754,7 +754,7 @@ static void createCDKScrollItemList (CDKSCROLL *scrollp, boolean numbers, char *
{
for (x=0 ; x < listSize; x++)
{
sprintf (temp, "%4d. %s", x + 1, list[x]);
snprintf (temp, sizeof(temp), "%4d. %s", x + 1, list[x]);
scrollp->item[x] = char2Chtype (temp, &scrollp->itemLen[x], &scrollp->itemPos[x]);
scrollp->itemPos[x] = justifyString (scrollp->fieldWidth, scrollp->itemLen[x], scrollp->itemPos[x]);
widestItem = MAXIMUM (widestItem, scrollp->itemLen[x]);
@ -864,7 +864,7 @@ void addCDKScrollItem (CDKSCROLL *scrollp, char *item)
*/
if (scrollp->numbers == NUMBERS)
{
sprintf (temp, "%4d. %s", itemNumber + 1, item);
snprintf (temp, sizeof(temp), "%4d. %s", itemNumber + 1, item);
scrollp->item[itemNumber] = char2Chtype (temp, &scrollp->itemLen[itemNumber], &scrollp->itemPos[itemNumber]);
scrollp->itemPos[itemNumber] = justifyString (scrollp->fieldWidth, scrollp->itemLen[itemNumber], scrollp->itemPos[itemNumber]);
}