Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Convert an aprint_error_dev() to ACPI_DEBUG_PRINT in acpi_power_set().

Browse Source 
This "fixes" the issue observed by dyoung@. Since the AML may not keep any
state by itself, it is possible that the firmware tries to continuously put
a device into a power state where the device already is (e.g. D3 -> D3).

XXX: The code (like the old power resource code) rests on the assumption
     that it is possible to reliably obtain the power state of a device
     either directly via _PSC or indirectly via _STA. However, because there
     is some evidence that few broken systems implement these methods
     incorrectly (e.g. always returns D0 as a constant, even if the state
     would be D3 in reality), we may need to revisit this by always setting
     the power state, even if it is impossible to get the power state.
This commit is contained in:
jruoho 2010-06-05 07:59:13 +00:00
parent 1f4ce9efc5
commit 8e7819f753
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/dev/acpi/acpi_power.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: acpi_power.c,v 1.13 2010/05/31 20:10:56 jruoho Exp $ */
/* $NetBSD: acpi_power.c,v 1.14 2010/06/05 07:59:13 jruoho Exp $ */
/*-
* Copyright (c) 2009, 2010 The NetBSD Foundation, Inc.
@ -56,7 +56,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: acpi_power.c,v 1.13 2010/05/31 20:10:56 jruoho Exp $");
__KERNEL_RCSID(0, "$NetBSD: acpi_power.c,v 1.14 2010/06/05 07:59:13 jruoho Exp $");
#include <sys/param.h>
#include <sys/kmem.h>
@ -379,8 +379,8 @@ acpi_power_set(struct acpi_devnode *ad, int state)
KASSERT(ad != NULL && ad->ad_root != NULL);
if ((ad->ad_flags & ACPI_DEVICE_POWER) == 0) {
ad->ad_state = ACPI_STATE_ERROR;
return false;
rv = AE_SUPPORT;
goto fail;
}
if (state < ACPI_STATE_D0 || state > ACPI_STATE_D3) {
@ -443,8 +443,8 @@ acpi_power_set(struct acpi_devnode *ad, int state)
fail:
ad->ad_state = ACPI_STATE_ERROR;
aprint_error_dev(ad->ad_root, "failed to set power state to D%d "
"for %s: %s\n", state, ad->ad_name, AcpiFormatException(rv));
ACPI_DEBUG_PRINT((ACPI_DB_INFO, "failed to set power state to D%d "
"for %s: %s\n", state, ad->ad_name, AcpiFormatException(rv)));
return false;
}