Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't use atomic_{set,clear}_bit nor any atomic op. These used to wrap

Browse Source 
atomic_{clear,set}_bit around munging a device register and that is clearly
wrong.  Instead directly manipulate the CPSR to disable interrupts.
This commit is contained in:
matt 2008-11-19 06:37:51 +00:00
parent ca9e0ec672
commit 8856d1852f
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sys/arch/arm/s3c2xx0/s3c2410_intr.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: s3c2410_intr.c,v 1.9 2008/04/27 18:58:45 matt Exp $ */
/* $NetBSD: s3c2410_intr.c,v 1.10 2008/11/19 06:37:51 matt Exp $ */
/*
* Copyright (c) 2003 Genetec corporation. All rights reserved.
@ -35,7 +35,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: s3c2410_intr.c,v 1.9 2008/04/27 18:58:45 matt Exp $");
__KERNEL_RCSID(0, "$NetBSD: s3c2410_intr.c,v 1.10 2008/11/19 06:37:51 matt Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@ -316,15 +316,17 @@ s3c2410_intr_init(struct s3c24x0_softc *sc)
void
s3c2410_mask_subinterrupts(int bits)
{
atomic_set_bit((uint32_t *)__UNVOLATILE(&icreg(INTCTL_INTSUBMSK)),
bits);
int psw = disable_interrupts(IF32_bits);
icreg(INTCTL_INTSUBMSK |= bits;
restore_interrupts(psw);
}
void
s3c2410_unmask_subinterrupts(int bits)
{
atomic_clear_bit((uint32_t *)__UNVOLATILE(&icreg(INTCTL_INTSUBMSK)),
bits);
int psw = disable_interrupts(IF32_bits);
icreg(INTCTL_INTSUBMSK) &= ~bits;
restore_interrupts(psw);
}
/*