Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

don't return errno from a function which returns an fd - there's 

a "little" room for confusion.  instead, return -1 and let the
caller grab errno.
This commit is contained in:
pooka 2007-06-24 17:41:09 +00:00
parent cf3eceb66e
commit 86e63e7e27
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/libpuffs/null.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: null.c,v 1.14 2007/06/06 01:55:01 pooka Exp $ */
/* $NetBSD: null.c,v 1.15 2007/06/24 17:41:09 pooka Exp $ */
/*
* Copyright (c) 2007 Antti Kantee. All Rights Reserved.
@ -27,7 +27,7 @@
#include <sys/cdefs.h>
#if !defined(lint)
__RCSID("$NetBSD: null.c,v 1.14 2007/06/06 01:55:01 pooka Exp $");
__RCSID("$NetBSD: null.c,v 1.15 2007/06/24 17:41:09 pooka Exp $");
#endif /* !lint */
/*
@ -102,11 +102,11 @@ writeableopen(const char *path)
if (fd == -1) {
if (errno == EACCES) {
if (stat(path, &sb) == -1)
return errno;
return -1;
origmode = sb.st_mode & ALLPERMS;
if (chmod(path, 0200) == -1)
return errno;
return -1;
fd = open(path, O_WRONLY);
if (fd == -1)
@ -116,7 +116,7 @@ writeableopen(const char *path)
if (sverr)
errno = sverr;
} else
return errno;
return -1;
}
return fd;