Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make(1): reduce number of test cases in sh-flags.mk 

The field job->echo is initialized in JobStart (and in JobOpenTmpFile).
After that, it is not modified anymore.  Therefore it is not necessary
to run these test cases redundantly.

The field job->ignerr, on the other hand, is modified later on.  For
these cases, the many remaining test cases are still needed.
This commit is contained in:
rillig 2020-12-12 12:19:18 +00:00
parent c9c491710a
commit 8538421bd4
2 changed files with 4 additions and 4147 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4144
usr.bin/make/unit-tests/sh-flags.exp
View File

File diff suppressed because it is too large Load Diff

7
usr.bin/make/unit-tests/sh-flags.mk
View File

@ -1,4 +1,4 @@
# $NetBSD: sh-flags.mk,v 1.3 2020/12/12 12:13:12 rillig Exp $
# $NetBSD: sh-flags.mk,v 1.4 2020/12/12 12:19:18 rillig Exp $
#
# Tests for the effective RunFlags of a shell command (run/skip, echo/silent,
# error check, trace), which are controlled by 12 different switches. These
@ -42,7 +42,8 @@ letter.xtrace.yes= x
.for opt-jobs in no yes
.for opt-loud in no yes
.for opt-no-action in no yes
.for opt-silent in no yes
# Only 'no', not 'yes', since job->echo is based trivially on opts.silent.
.for opt-silent in no
# Only 'no', not 'yes', since that would add uncontrollable output from
# reading /etc/profile or similar files.
.for opt-xtrace in no
@ -111,7 +112,7 @@ ${target}: .MAKE
.if ${tgt-ignerr} == yes
${target}: .IGNORE
.endif
.if ${tgt-silent} == yes || ${OPT_TARGET:M*s*}
.if ${tgt-silent} == yes
${target}: .SILENT
.endif