Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Changing type of "c" to unsigned did not fix the problem --- a signed 

char is sign extended before it is assigned to an unsigned int.  This
fix, which has been tested with a different testcase, adds explicit
casts to unsigned char before the value of a character is copied.
This commit is contained in:
jtc 1996-07-20 01:00:55 +00:00
parent 00933138c8
commit 83481cc8e8
2 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/libc/stdlib/strtol.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: strtol.c,v 1.8 1996/07/11 01:47:41 jtc Exp $ */
/* $NetBSD: strtol.c,v 1.9 1996/07/20 01:00:55 jtc Exp $ */
/*-
* Copyright (c) 1990 The Regents of the University of California.
@ -37,7 +37,7 @@
#if 0
static char *sccsid = "from: @(#)strtol.c 5.4 (Berkeley) 2/23/91";
#else
static char *rcsid = "$NetBSD: strtol.c,v 1.8 1996/07/11 01:47:41 jtc Exp $";
static char *rcsid = "$NetBSD: strtol.c,v 1.9 1996/07/20 01:00:55 jtc Exp $";
#endif
#endif /* LIBC_SCCS and not lint */
@ -61,7 +61,7 @@ strtol(nptr, endptr, base)
{
register const char *s;
register long acc, cutoff;
register unsigned int c;
register int c;
register int neg, any, cutlim;
/*
@ -71,7 +71,7 @@ strtol(nptr, endptr, base)
*/
s = nptr;
do {
c = *s++;
c = (unsigned char) *s++;
} while (isspace(c));
if (c == '-') {
neg = 1;
@ -117,7 +117,7 @@ strtol(nptr, endptr, base)
}
cutlim = -cutlim;
}
for (acc = 0, any = 0;; c = *s++) {
for (acc = 0, any = 0;; c = (unsigned char) *s++) {
if (isdigit(c))
c -= '0';
else if (isalpha(c))

10
lib/libc/stdlib/strtoul.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: strtoul.c,v 1.8 1996/07/11 01:47:38 jtc Exp $ */
/* $NetBSD: strtoul.c,v 1.9 1996/07/20 01:00:57 jtc Exp $ */
/*
* Copyright (c) 1990 Regents of the University of California.
@ -37,7 +37,7 @@
#if 0
static char *sccsid = "from: @(#)strtoul.c 5.3 (Berkeley) 2/23/91";
#else
static char *rcsid = "$NetBSD: strtoul.c,v 1.8 1996/07/11 01:47:38 jtc Exp $";
static char *rcsid = "$NetBSD: strtoul.c,v 1.9 1996/07/20 01:00:57 jtc Exp $";
#endif
#endif /* LIBC_SCCS and not lint */
@ -60,7 +60,7 @@ strtoul(nptr, endptr, base)
{
register const char *s;
register unsigned long acc, cutoff;
register unsigned int c;
register int c;
register int neg, any, cutlim;
/*
@ -68,7 +68,7 @@ strtoul(nptr, endptr, base)
*/
s = nptr;
do {
c = *s++;
c = (unsigned char) *s++;
} while (isspace(c));
if (c == '-') {
neg = 1;
@ -89,7 +89,7 @@ strtoul(nptr, endptr, base)
cutoff = ULONG_MAX / (unsigned long)base;
cutlim = ULONG_MAX % (unsigned long)base;
for (acc = 0, any = 0;; c = *s++) {
for (acc = 0, any = 0;; c = (unsigned char) *s++) {
if (isdigit(c))
c -= '0';
else if (isalpha(c))