From 7d9fce090dd31fddbfda260c961f7f49a0c76969 Mon Sep 17 00:00:00 2001 From: wiz Date: Sun, 17 Jan 2010 22:48:50 +0000 Subject: [PATCH] Only a return value below 0 denotes an error in open(2). Found by cppcheck. --- distrib/utils/sysinst/wskbd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/distrib/utils/sysinst/wskbd.c b/distrib/utils/sysinst/wskbd.c index 6918d3324463..2963891b1981 100644 --- a/distrib/utils/sysinst/wskbd.c +++ b/distrib/utils/sysinst/wskbd.c @@ -1,4 +1,4 @@ -/* $NetBSD: wskbd.c,v 1.8 2010/01/02 18:06:57 dsl Exp $ */ +/* $NetBSD: wskbd.c,v 1.9 2010/01/17 22:48:50 wiz Exp $ */ /*- * Copyright (c) 2003 The NetBSD Foundation, Inc. @@ -30,7 +30,7 @@ */ #include -__RCSID("$NetBSD: wskbd.c,v 1.8 2010/01/02 18:06:57 dsl Exp $"); +__RCSID("$NetBSD: wskbd.c,v 1.9 2010/01/17 22:48:50 wiz Exp $"); #include #include @@ -96,7 +96,7 @@ get_kb_encoding(void) const char *dflt = msg_string(MSG_kb_default); fd = open("/dev/wskbd0", O_WRONLY); - if (fd <= 0) + if (fd < 0) return; if (ioctl(fd, WSKBDIO_GETENCODING, &kbdencoding) >= 0) { memset(&opt, 0, sizeof opt);