From 7c9507a357c8f6f977be6787b8ae99cb08fd381f Mon Sep 17 00:00:00 2001 From: gdamore Date: Wed, 20 Sep 2006 05:37:22 +0000 Subject: [PATCH] Get rid of annoying and useless missed frame message, no other driver echos this "non-error" message (not even tulip.c). Included is an explanatory message stating that these counters should probably all be converted to evcnt counters. --- sys/arch/mips/alchemy/dev/if_aumac.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/sys/arch/mips/alchemy/dev/if_aumac.c b/sys/arch/mips/alchemy/dev/if_aumac.c index 848291666058..18ce81fddb39 100644 --- a/sys/arch/mips/alchemy/dev/if_aumac.c +++ b/sys/arch/mips/alchemy/dev/if_aumac.c @@ -1,4 +1,4 @@ -/* $NetBSD: if_aumac.c,v 1.17 2006/05/05 18:04:41 thorpej Exp $ */ +/* $NetBSD: if_aumac.c,v 1.18 2006/09/20 05:37:22 gdamore Exp $ */ /* * Copyright (c) 2001 Wasabi Systems, Inc. @@ -46,7 +46,7 @@ */ #include -__KERNEL_RCSID(0, "$NetBSD: if_aumac.c,v 1.17 2006/05/05 18:04:41 thorpej Exp $"); +__KERNEL_RCSID(0, "$NetBSD: if_aumac.c,v 1.18 2006/09/20 05:37:22 gdamore Exp $"); #include "bpfilter.h" #include "rnd.h" @@ -658,8 +658,20 @@ aumac_rxintr(struct aumac_softc *sc) if (stat & RX_STAT_ERRS) { int error = 0; +#if 0 /* + * Missed frames are a semi-frequent occurence with this hardware, + * and reporting of them just makes everything run slower and fills + * the system log. Be silent. + * + * Additionally, this missed bit indicates an error with the previous + * packet, and not with this one! So PRINTERR is definitely wrong + * here. + * + * These should probably all be converted to evcnt counters anyway. + */ if (stat & RX_STAT_MI) PRINTERR("missed frame"); +#endif if (stat & RX_STAT_UC) PRINTERR("unknown control frame"); if (stat & RX_STAT_LE)