Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make: ensure loop termination in purge_relative_cached_realpaths 

You cannot ignore the return from HashIter_Next
This commit is contained in:
sjg 2024-06-01 07:37:19 +00:00
parent cdcc95b114
commit 7aee84d4aa
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
usr.bin/make/main.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: main.c,v 1.619 2024/05/31 05:50:11 rillig Exp $ */
/* $NetBSD: main.c,v 1.620 2024/06/01 07:37:19 sjg Exp $ */
/*
* Copyright (c) 1988, 1989, 1990, 1993
@ -111,7 +111,7 @@
#include "trace.h"
/* "@(#)main.c 8.3 (Berkeley) 3/19/94" */
MAKE_RCSID("$NetBSD: main.c,v 1.619 2024/05/31 05:50:11 rillig Exp $");
MAKE_RCSID("$NetBSD: main.c,v 1.620 2024/06/01 07:37:19 sjg Exp $");
#if defined(MAKE_NATIVE)
__COPYRIGHT("@(#) Copyright (c) 1988, 1989, 1990, 1993 "
"The Regents of the University of California. "
@ -1971,12 +1971,13 @@ static void
purge_relative_cached_realpaths(void)
{
HashIter hi;
bool more;
HashIter_Init(&hi, &cached_realpaths);
HashIter_Next(&hi);
while (hi.entry != NULL) {
more = HashIter_Next(&hi);
while (more) {
HashEntry *he = hi.entry;
HashIter_Next(&hi);
more = HashIter_Next(&hi);
if (he->key[0] != '/') {
DEBUG1(DIR, "cached_realpath: purging %s\n", he->key);
HashTable_DeleteEntry(&cached_realpaths, he);