Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

aiboost_getcomp: use Package.Count to allocate and iterate over

Browse Source 
the elements rather than Integer.Value, which sometimes doesn't
match and gives unexpected results on the error path.

This fixes the kmem_poison_check on DEBUG kernels (finally). Patch
by Fukumoto Atsushi. Thanks!
This commit is contained in:
xtraeme 2008-02-01 23:12:30 +00:00
parent f6a680bbd6
commit 74a0270856
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/dev/acpi/aiboost.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: aiboost.c,v 1.21 2008/01/29 19:35:05 xtraeme Exp $ */
/* $NetBSD: aiboost.c,v 1.22 2008/02/01 23:12:30 xtraeme Exp $ */
/*-
* Copyright (c) 2007 Juan Romero Pardines
@ -28,7 +28,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: aiboost.c,v 1.21 2008/01/29 19:35:05 xtraeme Exp $");
__KERNEL_RCSID(0, "$NetBSD: aiboost.c,v 1.22 2008/02/01 23:12:30 xtraeme Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@ -333,13 +333,13 @@ aiboost_getcomp(ACPI_HANDLE *h, const char *name, struct aiboost_comp **comp)
}
clen = sizeof(struct aiboost_comp) + sizeof(struct aiboost_elem) *
(elem->Integer.Value - 1);
(o->Package.Count - 1);
c = kmem_zalloc(clen, KM_NOSLEEP);
if (!c)
goto error;
*comp = c;
c->num = elem->Integer.Value;
c->num = o->Package.Count - 1;
for (i = 1; i < o->Package.Count; i++) {
elem = &o->Package.Elements[i];