Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

There's no need to call pmap_tlb_invalidate_addr if pmap_remove_all was

Browse Source 
called and PMAP_DEFERRED_ACTIVATE is set.
This commit is contained in:
skrll 2017-09-07 06:29:47 +00:00
parent 50d91653ef
commit 67f418007a
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
sys/uvm/pmap/pmap.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: pmap.c,v 1.35 2017/06/24 07:30:17 skrll Exp $ */ /* $NetBSD: pmap.c,v 1.36 2017/09/07 06:29:47 skrll Exp $ */
/*- /*-
* Copyright (c) 1998, 2001 The NetBSD Foundation, Inc. * Copyright (c) 1998, 2001 The NetBSD Foundation, Inc.
@ -67,7 +67,7 @@
#include <sys/cdefs.h> #include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: pmap.c,v 1.35 2017/06/24 07:30:17 skrll Exp $"); __KERNEL_RCSID(0, "$NetBSD: pmap.c,v 1.36 2017/09/07 06:29:47 skrll Exp $");
/* /*
* Manages physical address maps. * Manages physical address maps.
@ -774,10 +774,12 @@ pmap_page_remove(struct vm_page *pg)
pmap_md_tlb_miss_lock_enter(); pmap_md_tlb_miss_lock_enter();
const pt_entry_t npte = pte_nv_entry(is_kernel_pmap_p); const pt_entry_t npte = pte_nv_entry(is_kernel_pmap_p);
pte_set(ptep, npte); pte_set(ptep, npte);
/* if (__predict_true(!(pmap->pm_flags & PMAP_DEFERRED_ACTIVATE))) {
* Flush the TLB for the given address. /*
*/ * Flush the TLB for the given address.
pmap_tlb_invalidate_addr(pmap, va); */
pmap_tlb_invalidate_addr(pmap, va);
}
pmap_md_tlb_miss_lock_exit(); pmap_md_tlb_miss_lock_exit();
/* /*
@ -903,10 +905,13 @@ pmap_pte_remove(pmap_t pmap, vaddr_t sva, vaddr_t eva, pt_entry_t *ptep,
} }
pmap_md_tlb_miss_lock_enter(); pmap_md_tlb_miss_lock_enter();
pte_set(ptep, npte); pte_set(ptep, npte);
/* if (__predict_true(!(pmap->pm_flags & PMAP_DEFERRED_ACTIVATE))) {
* Flush the TLB for the given address.
*/ /*
pmap_tlb_invalidate_addr(pmap, sva); * Flush the TLB for the given address.
*/
pmap_tlb_invalidate_addr(pmap, sva);
}
pmap_md_tlb_miss_lock_exit(); pmap_md_tlb_miss_lock_exit();
} }