Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

CREATE is a write operation in my book, so check for that also when 

checking for a readonly lookup.  This shouldn't make a difference
now, though, as the only RDONLY lookup is done by getcwd(), and
that a) doesn't create files b) calls LOOKUP directly anyway.

Also, fix comment I managed to miss in the previous commit (I didn't
expect the same comment to be there twice).
This commit is contained in:
pooka 2007-08-12 19:42:09 +00:00
parent 5450d0d87b
commit 67c57c75e0
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/kern/vfs_lookup.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: vfs_lookup.c,v 1.94 2007/08/12 19:31:12 pooka Exp $ */
/* $NetBSD: vfs_lookup.c,v 1.95 2007/08/12 19:42:09 pooka Exp $ */
/*
* Copyright (c) 1982, 1986, 1989, 1993
@ -37,7 +37,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: vfs_lookup.c,v 1.94 2007/08/12 19:31:12 pooka Exp $");
__KERNEL_RCSID(0, "$NetBSD: vfs_lookup.c,v 1.95 2007/08/12 19:42:09 pooka Exp $");
#include "opt_ktrace.h"
#include "opt_systrace.h"
@ -890,12 +890,8 @@ terminal:
* Disallow directory write attempts on read-only lookups.
*/
if (rdonly &&
(cnp->cn_nameiop == DELETE || cnp->cn_nameiop == RENAME)) {
/*
* Disallow directory write attempts on read-only
* file systems.
*/
(cnp->cn_nameiop == DELETE || cnp->cn_nameiop == RENAME ||
cnp->cn_nameiop == CREATE)) {
error = EROFS;
if (dp != ndp->ni_dvp) {
vput(dp);