Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

How did this bug survive for so long? 'who am i' was busted because

Browse Source 
it checked for valid utmp entries with usr.ut_name != NULL which can
never happen ofcourse, instead of usr.ut_name[0] != '\0'
This commit is contained in:
christos 1999-07-17 16:41:44 +00:00
parent 936dae3338
commit 6653fa8b3c
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
usr.bin/who/who.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: who.c,v 1.7 1998/12/20 14:53:24 christos Exp $ */
/* $NetBSD: who.c,v 1.8 1999/07/17 16:41:44 christos Exp $ */
/*
* Copyright (c) 1989, 1993
@ -47,7 +47,7 @@ __COPYRIGHT(
#if 0
static char sccsid[] = "@(#)who.c 8.1 (Berkeley) 6/6/93";
#endif
__RCSID("$NetBSD: who.c,v 1.7 1998/12/20 14:53:24 christos Exp $");
__RCSID("$NetBSD: who.c,v 1.8 1999/07/17 16:41:44 christos Exp $");
#endif /* not lint */
#include <sys/types.h>
@ -165,7 +165,8 @@ who_am_i(ufp)
if ((t = strrchr(p, '/')) != NULL)
p = t + 1;
while (fread((char *)&usr, sizeof(usr), 1, ufp) == 1)
if (usr.ut_name && !strcmp(usr.ut_line, p)) {
if (usr.ut_name[0] != '\0' &&
!strcmp(usr.ut_line, p)) {
output(&usr);
return;
}