Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use PAGE_SIZE chunks, not VERIEXEC_BUFSIZE - it's very important that the 

size is not arbitrary and is exactly the size of a page.
This commit is contained in:
elad 2005-05-28 16:37:20 +00:00
parent 189ffc4458
commit 65b04a0bf1
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sys/kern/kern_verifiedexec.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: kern_verifiedexec.c,v 1.17 2005/05/28 15:49:36 elad Exp $ */ /* $NetBSD: kern_verifiedexec.c,v 1.18 2005/05/28 16:37:20 elad Exp $ */
/*- /*-
* Copyright 2005 Elad Efrat <elad@bsd.org.il> * Copyright 2005 Elad Efrat <elad@bsd.org.il>
@ -30,7 +30,7 @@
*/ */
#include <sys/cdefs.h> #include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: kern_verifiedexec.c,v 1.17 2005/05/28 15:49:36 elad Exp $"); __KERNEL_RCSID(0, "$NetBSD: kern_verifiedexec.c,v 1.18 2005/05/28 16:37:20 elad Exp $");
#include <sys/param.h> #include <sys/param.h>
#include <sys/mount.h> #include <sys/mount.h>
@ -65,8 +65,6 @@ struct sysctlnode *veriexec_count_node = NULL;
/* Veriexecs table of hash types and their associated information. */ /* Veriexecs table of hash types and their associated information. */
LIST_HEAD(veriexec_ops_head, veriexec_fp_ops) veriexec_ops_list; LIST_HEAD(veriexec_ops_head, veriexec_fp_ops) veriexec_ops_list;
#define VERIEXEC_BUFSIZE PAGE_SIZE
/* /*
* Add fingerprint names to the global list. * Add fingerprint names to the global list.
*/ */
@ -221,7 +219,7 @@ veriexec_fp_calc(struct proc *p, struct vnode *vp,
ctx = (void *) malloc(vhe->ops->context_size, M_TEMP, M_WAITOK); ctx = (void *) malloc(vhe->ops->context_size, M_TEMP, M_WAITOK);
buf = (u_char *) malloc(VERIEXEC_BUFSIZE, M_TEMP, M_WAITOK); buf = (u_char *) malloc(PAGE_SIZE, M_TEMP, M_WAITOK);
(vhe->ops->init)(ctx); /* init the fingerprint context */ (vhe->ops->init)(ctx); /* init the fingerprint context */
@ -229,9 +227,9 @@ veriexec_fp_calc(struct proc *p, struct vnode *vp,
* The vnode is locked. sys_execve() does it for us; We have our * The vnode is locked. sys_execve() does it for us; We have our
* own locking in vn_open(). * own locking in vn_open().
*/ */
for (offset = 0; offset < size; offset += VERIEXEC_BUFSIZE) { for (offset = 0; offset < size; offset += PAGE_SIZE) {
len = ((size - offset) < VERIEXEC_BUFSIZE) ? (size - offset) len = ((size - offset) < PAGE_SIZE) ? (size - offset)
: VERIEXEC_BUFSIZE; : PAGE_SIZE;
error = vn_rdwr(UIO_READ, vp, buf, len, offset, error = vn_rdwr(UIO_READ, vp, buf, len, offset,
UIO_SYSSPACE, UIO_SYSSPACE,