Aren/NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Two uninitialized vars, found by brainy. The former is similar to the one

Browse Source 
I fixed in ia64/stand/efi/libefi/devicename.c. I don't know how to fix the
latter, so just add a comment. I will probably file a PR for this one.
This commit is contained in:
maxv 2016-08-15 09:06:39 +00:00
parent 1b256e1a4d
commit 631d00ff2f
1 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
sys/arch/ia64/stand/ia64/ski/devicename.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: devicename.c,v 1.7 2014/04/08 21:51:06 martin Exp $ */
/* $NetBSD: devicename.c,v 1.8 2016/08/15 09:06:39 maxv Exp $ */
/*-
* Copyright (c) 1998 Michael Smith <msmith@freebsd.org>
@ -91,7 +91,7 @@ ski_parsedev(struct ski_devdesc **dev, const char *devspec, const char **path)
struct devsw *dv;
int dv_type;
int i, unit, slice, partition, err;
char *cp;
char *cp = NULL;
const char *np;
/* minimum length check */
@ -146,6 +146,10 @@ ski_parsedev(struct ski_devdesc **dev, const char *devspec, const char **path)
cp++;
}
}
if (cp == NULL) {
err = EINVAL;
goto fail;
}
if (*cp && (*cp != ':')) {
err = EINVAL;
goto fail;
@ -169,6 +173,10 @@ ski_parsedev(struct ski_devdesc **dev, const char *devspec, const char **path)
goto fail;
}
}
if (cp == NULL) {
err = EINVAL;
goto fail;
}
if (*cp && (*cp != ':')) {
err = EINVAL;
goto fail;
@ -228,6 +236,7 @@ ski_fmtdev(void *vdev)
break;
case DEVT_NET:
/* XXX XXX XXX: Yay, 'len' is not initialized here */
snprintf(buf, buflen - len, "%s%d:", dev->d_dev->dv_name, dev->d_kind.netif.unit);
break;
}