Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Initialize `struct consdev` members cn_dev and cn_pri like other 

UART drivers do.  If cn_dev is 0 instead of NODEV, then the kernel
may redirect console writes to major 0, minor 0, which is /dev/mem.
On my Zynq board the kernel overwrote the page free list with a
console message in this way.
This commit is contained in:
dyoung 2024-05-04 02:04:54 +00:00
parent 7db2523dea
commit 5fb492e854
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/arch/arm/xilinx/zynq_uart.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: zynq_uart.c,v 1.5 2022/10/27 07:57:46 skrll Exp $ */
/* $NetBSD: zynq_uart.c,v 1.6 2024/05/04 02:04:54 dyoung Exp $ */
/*
* Copyright (c) 2012 Genetec Corporation. All rights reserved.
@ -96,7 +96,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: zynq_uart.c,v 1.5 2022/10/27 07:57:46 skrll Exp $");
__KERNEL_RCSID(0, "$NetBSD: zynq_uart.c,v 1.6 2024/05/04 02:04:54 dyoung Exp $");
#include "opt_soc.h"
#include "opt_console.h"
@ -1974,7 +1974,9 @@ zynquart_init(struct zynquart_regs *regsp, int rate, tcflag_t cflag)
struct consdev zynquartcons = {
.cn_getc = zynquartcngetc,
.cn_putc = zynquartcnputc,
.cn_pollc = nullcnpollc
.cn_pollc = nullcnpollc,
.cn_dev = NODEV,
.cn_pri = CN_NORMAL,
};