Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

make(1): inline local variable in Dir_UpdateMTime 

Now that the signature of cached_stats is cleaned up, the line is short
enough to contain the whole condition.
This commit is contained in:
rillig 2020-11-14 19:36:31 +00:00
parent 33ac710bcd
commit 5cb24dfe8b
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
usr.bin/make/dir.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: dir.c,v 1.208 2020/11/14 19:24:24 rillig Exp $ */
/* $NetBSD: dir.c,v 1.209 2020/11/14 19:36:31 rillig Exp $ */
/*
* Copyright (c) 1988, 1989, 1990 The Regents of the University of California.
@ -134,7 +134,7 @@
#include "job.h"
/* "@(#)dir.c 8.2 (Berkeley) 1/2/94" */
MAKE_RCSID("$NetBSD: dir.c,v 1.208 2020/11/14 19:24:24 rillig Exp $");
MAKE_RCSID("$NetBSD: dir.c,v 1.209 2020/11/14 19:36:31 rillig Exp $");
#define DIR_DEBUG0(text) DEBUG0(DIR, text)
#define DIR_DEBUG1(fmt, arg1) DEBUG1(DIR, fmt, arg1)
@ -1279,7 +1279,6 @@ Dir_UpdateMTime(GNode *gn, Boolean recheck)
{
char *fullName;
struct cached_stat cst;
CachedStatsFlags flags;
if (gn->type & OP_ARCHV) {
Arch_UpdateMTime(gn);
@ -1334,8 +1333,7 @@ Dir_UpdateMTime(GNode *gn, Boolean recheck)
if (fullName == NULL)
fullName = bmake_strdup(gn->name);
flags = recheck ? CST_UPDATE : CST_NONE;
if (cached_stats(fullName, &cst, flags) < 0) {
if (cached_stats(fullName, &cst, recheck ? CST_UPDATE : CST_NONE) < 0) {
if (gn->type & OP_MEMBER) {
if (fullName != gn->path)
free(fullName);