Coverity CID 1103: Avoid NULL pointer deref.

This commit is contained in:
christos 2006-04-14 17:58:01 +00:00
parent cbf7d00ad2
commit 53daf02156
1 changed files with 4 additions and 3 deletions

View File

@ -1,4 +1,4 @@
/* $NetBSD: mly.c,v 1.25 2006/04/14 17:54:26 christos Exp $ */
/* $NetBSD: mly.c,v 1.26 2006/04/14 17:58:01 christos Exp $ */
/*-
* Copyright (c) 2001 The NetBSD Foundation, Inc.
@ -77,7 +77,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: mly.c,v 1.25 2006/04/14 17:54:26 christos Exp $");
__KERNEL_RCSID(0, "$NetBSD: mly.c,v 1.26 2006/04/14 17:58:01 christos Exp $");
#include <sys/param.h>
#include <sys/systm.h>
@ -984,7 +984,8 @@ mly_ioctl(struct mly_softc *mly, struct mly_cmd_ioctl *ioctl, void **data,
bad:
if (mc != NULL) {
/* Do we need to free a data buffer we allocated? */
if (rv != 0 && mc->mc_data != NULL && *data == NULL)
if (rv != 0 && mc->mc_data != NULL &&
(data == NULL || *data == NULL))
free(mc->mc_data, M_DEVBUF);
mly_ccb_free(mly, mc);
}