Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add refcnt constraint checks for debugging 

It's useful to know where the constraint is violated (by extra rtfree).
It's enabled only if DEBUG because it's heavy (O(n)).
This commit is contained in:
ozaki-r 2015-09-03 02:04:31 +00:00
parent 1d638ab7bf
commit 5392bf8aeb
1 changed files with 26 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
sys/net/route.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: route.c,v 1.150 2015/08/31 06:25:15 ozaki-r Exp $ */
/* $NetBSD: route.c,v 1.151 2015/09/03 02:04:31 ozaki-r Exp $ */
/*-
* Copyright (c) 1998, 2008 The NetBSD Foundation, Inc.
@ -96,7 +96,7 @@
#endif
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: route.c,v 1.150 2015/08/31 06:25:15 ozaki-r Exp $");
__KERNEL_RCSID(0, "$NetBSD: route.c,v 1.151 2015/09/03 02:04:31 ozaki-r Exp $");
#include <sys/param.h>
#ifdef RTFLUSH_DEBUG
@ -410,6 +410,26 @@ rtalloc1(const struct sockaddr *dst, int report)
return newrt;
}
#ifdef DEBUG
/*
* Check the following constraint for each rtcache:
* if a rtcache holds a rtentry, the rtentry's refcnt is more than zero,
* i.e., the rtentry should be referenced at least by the rtcache.
*/
static void
rtcache_check_rtrefcnt(int family)
{
struct domain *dom = pffinddomain(family);
struct route *ro;
if (dom == NULL)
return;
LIST_FOREACH(ro, &dom->dom_rtcache, ro_rtcache_next)
KDASSERT(ro->_ro_rt == NULL || ro->_ro_rt->rt_refcnt > 0);
}
#endif
void
rtfree(struct rtentry *rt)
{
@ -419,6 +439,10 @@ rtfree(struct rtentry *rt)
KASSERT(rt->rt_refcnt > 0);
rt->rt_refcnt--;
#ifdef DEBUG
if (rt_getkey(rt) != NULL)
rtcache_check_rtrefcnt(rt_getkey(rt)->sa_family);
#endif
if (rt->rt_refcnt == 0 && (rt->rt_flags & RTF_UP) == 0) {
rt_assert_inactive(rt);
rttrash--;