From 5242bed266a14ca7812f2f8a5230eb3e5917324d Mon Sep 17 00:00:00 2001
From: rillig <rillig@NetBSD.org>
Date: Tue, 19 Apr 2022 22:40:13 +0000
Subject: [PATCH] tests/lint: add test case for integer non-constant expression

Seen in sqlite3.c.
---
 tests/usr.bin/xlint/lint1/msg_132.c   | 17 ++++++++++++++++-
 tests/usr.bin/xlint/lint1/msg_132.exp |  1 +
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/tests/usr.bin/xlint/lint1/msg_132.c b/tests/usr.bin/xlint/lint1/msg_132.c
index 3b1c30f2d309..ef7603cf21b7 100644
--- a/tests/usr.bin/xlint/lint1/msg_132.c
+++ b/tests/usr.bin/xlint/lint1/msg_132.c
@@ -1,4 +1,4 @@
-/*	$NetBSD: msg_132.c,v 1.6 2021/08/25 22:04:52 rillig Exp $	*/
+/*	$NetBSD: msg_132.c,v 1.7 2022/04/19 22:40:13 rillig Exp $	*/
 # 3 "msg_132.c"
 
 // Test for message: conversion from '%s' to '%s' may lose accuracy [132]
@@ -85,3 +85,18 @@ cover_build_plus_minus(const char *arr, double idx)
 		return arr + idx;
 	return arr + (unsigned int)idx;
 }
+
+int
+non_constant_expression(void)
+{
+	/*
+	 * Even though this variable definition looks like a constant, it
+	 * does not fall within C's definition of an integer constant
+	 * expression.  Due to that, lint does not perform constant folding
+	 * on the expression built from this variable and thus doesn't know
+	 * that the conversion will always succeed.
+	 */
+	const int not_a_constant = 8;
+	/* expect+1: warning: conversion from 'unsigned long' to 'int' may lose accuracy [132] */
+	return sizeof(double) + not_a_constant * sizeof(char *);
+}
diff --git a/tests/usr.bin/xlint/lint1/msg_132.exp b/tests/usr.bin/xlint/lint1/msg_132.exp
index 6f7536d90f9b..278ee5b03536 100644
--- a/tests/usr.bin/xlint/lint1/msg_132.exp
+++ b/tests/usr.bin/xlint/lint1/msg_132.exp
@@ -12,3 +12,4 @@ msg_132.c(55): warning: conversion from 'long long' to 'short' may lose accuracy
 msg_132.c(59): warning: conversion from 'long long' to 'int' may lose accuracy [132]
 msg_132.c(85): error: operands of '+' have incompatible types (pointer != double) [107]
 msg_132.c(85): warning: function 'cover_build_plus_minus' expects to return value [214]
+msg_132.c(101): warning: conversion from 'unsigned long' to 'int' may lose accuracy [132]