Aren
/
NetBSD
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

The UID_MAX limit is not enforced by syscalls such as setreuid(2), 

so I remove the assertion uid >= 0 && uid <= UID_MAX.  This squashes
a bug where Quagga would panic my machine by passing a UID outside
the range [0, UID_MAX].

AFAICT, this restores the historical (pre-kauth) behavior.

It is likely that GIDs do not satisfy the assertion gid >= 0 &&
gid <= GID_MAX, so remove that, too.

Patch from elad.
This commit is contained in:
dyoung 2006-06-13 22:56:46 +00:00
parent 2e91d940da
commit 5174aa84b6
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/kern/kern_auth.c
View File

@ -1,4 +1,4 @@
/* $NetBSD: kern_auth.c,v 1.7 2006/06/13 13:56:50 yamt Exp $ */
/* $NetBSD: kern_auth.c,v 1.8 2006/06/13 22:56:46 dyoung Exp $ */
/*-
* Copyright (c) 2005, 2006 Elad Efrat <elad@NetBSD.org>
@ -247,7 +247,6 @@ void
kauth_cred_setuid(kauth_cred_t cred, uid_t uid)
{
KASSERT(cred != NULL);
KASSERT(uid >= 0 && uid <= UID_MAX);
cred->cr_uid = uid;
}
@ -256,7 +255,6 @@ void
kauth_cred_seteuid(kauth_cred_t cred, uid_t uid)
{
KASSERT(cred != NULL);
KASSERT(uid >= 0 && uid <= UID_MAX);
cred->cr_euid = uid;
}
@ -265,7 +263,6 @@ void
kauth_cred_setsvuid(kauth_cred_t cred, uid_t uid)
{
KASSERT(cred != NULL);
KASSERT(uid >= 0 && uid <= UID_MAX);
cred->cr_svuid = uid;
}
@ -274,7 +271,6 @@ void
kauth_cred_setgid(kauth_cred_t cred, gid_t gid)
{
KASSERT(cred != NULL);
KASSERT(gid >= 0 && gid <= GID_MAX);
cred->cr_gid = gid;
}
@ -283,7 +279,6 @@ void
kauth_cred_setegid(kauth_cred_t cred, gid_t gid)
{
KASSERT(cred != NULL);
KASSERT(gid >= 0 && gid <= GID_MAX);
cred->cr_egid = gid;
}
@ -292,7 +287,6 @@ void
kauth_cred_setsvgid(kauth_cred_t cred, gid_t gid)
{
KASSERT(cred != NULL);
KASSERT(gid >= 0 && gid <= GID_MAX);
cred->cr_svgid = gid;
}
@ -304,7 +298,6 @@ kauth_cred_ismember_gid(kauth_cred_t cred, gid_t gid, int *resultp)
int i;
KASSERT(cred != NULL);
KASSERT(gid >= 0 && gid <= GID_MAX);
KASSERT(resultp != NULL);
*resultp = 0;