Avoid Undefined Behavior in pr_item_notouch_get()

Change the type of left shifted integer from signed to unsigned.

sys/kern/subr_pool.c:274:13, left shift of 1 by 31 places cannot be represented in type 'int'

Detected with Kernel Undefined Behavior Sanitizer.

Reported by <Harry Pantazis>
This commit is contained in:
kamil 2018-07-04 01:42:37 +00:00
parent 7d17e9990f
commit 501bcee4da

View File

@ -1,4 +1,4 @@
/* $NetBSD: subr_pool.c,v 1.221 2018/01/12 18:54:37 para Exp $ */
/* $NetBSD: subr_pool.c,v 1.222 2018/07/04 01:42:37 kamil Exp $ */
/*-
* Copyright (c) 1997, 1999, 2000, 2002, 2007, 2008, 2010, 2014, 2015
@ -33,7 +33,7 @@
*/
#include <sys/cdefs.h>
__KERNEL_RCSID(0, "$NetBSD: subr_pool.c,v 1.221 2018/01/12 18:54:37 para Exp $");
__KERNEL_RCSID(0, "$NetBSD: subr_pool.c,v 1.222 2018/07/04 01:42:37 kamil Exp $");
#ifdef _KERNEL_OPT
#include "opt_ddb.h"
@ -271,7 +271,7 @@ pr_item_notouch_get(const struct pool *pp, struct pool_item_header *ph)
bit--;
idx = (i * BITMAP_SIZE) + bit;
mask = 1 << bit;
mask = 1U << bit;
KASSERT((bitmap[i] & mask) != 0);
bitmap[i] &= ~mask;
break;