From 4f90b9c42a081b60dde6ec613d3cab33f74570a9 Mon Sep 17 00:00:00 2001 From: mrg Date: Tue, 5 Feb 2019 07:27:46 +0000 Subject: [PATCH] - pass correct size of buffer to snprintf() to avoid potential truncation --- external/bsd/tcpdump/dist/print-hncp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/external/bsd/tcpdump/dist/print-hncp.c b/external/bsd/tcpdump/dist/print-hncp.c index 5ee7b4e419f5..06fd7c2a9f86 100644 --- a/external/bsd/tcpdump/dist/print-hncp.c +++ b/external/bsd/tcpdump/dist/print-hncp.c @@ -28,7 +28,7 @@ #include #ifndef lint -__RCSID("$NetBSD: print-hncp.c,v 1.4 2017/09/08 14:01:13 christos Exp $"); +__RCSID("$NetBSD: print-hncp.c,v 1.5 2019/02/05 07:27:46 mrg Exp $"); #endif /* \summary: Home Networking Control Protocol (HNCP) printer */ @@ -177,7 +177,7 @@ format_256(const u_char *data) static char buf[4][64+5]; static int i = 0; i = (i + 1) % 4; - snprintf(buf[i], 28, "%016" PRIx64 "%016" PRIx64 "%016" PRIx64 "%016" PRIx64, + snprintf(buf[i], sizeof buf[i], "%016" PRIx64 "%016" PRIx64 "%016" PRIx64 "%016" PRIx64, EXTRACT_64BITS(data), EXTRACT_64BITS(data + 8), EXTRACT_64BITS(data + 16),